backtrace_error_handler missing error constants causing notice. [#394078]

After doing the following typo in PHP 5.2.9: $string = '_'. $object-type (Supposed to be $object->type) I got two notices:

Notice: Undefined offset: 4096 in C:\dev\Aspedia\Projects\Drupal\clean\sites\all\modules\devel\devel.module on line 462, and the same again on line 472.

Seems you are missing the constant E_RECOVERABLE_ERROR(4096) which was added in php 5.2. (There are also a few others added in 5.3).

Also, as a side issue, could it be useful for readability sakes to create the $types array using the actual PHP constants rather than their number?

PHP docs for reference: http://php.net/manual/en/errorfunc.constants.php

Comment	File	Size	Author
#3	devel-394078-1.patch	1.42 KB	cdale
#3
#2	devel-394078.patch	1.39 KB	cdale
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 10 April 2009 at 14:53

Please provide a patch if possible.

Comment #2

cdale CreditAttribution: cdale commented 10 April 2009 at 23:28

File	Size
devel-394078.patch	1.39 KB

Patch attached.

Comment #3

cdale CreditAttribution: cdale commented 10 April 2009 at 23:35

File	Size
devel-394078-1.patch	1.42 KB

Oops. I just realized why the numbers are a better option than the constants. Not all constants are defined in all version of PHP. :) Proper patch attached.