Today i was trying to remove paypal express buttons from my cart. It took a long time and an irc talk to find the settings to remove it.

While i agree, activating/inactivating the two different occurences of the method makes sense such as:
/admin/store/settings/cart/edit/panes
/admin/store/settings/payment/edit/methods

I still believe all express buttons should disappear if i completely disable the gateway.
/admin/store/settings/payment/edit/gateways
Form, Checkbox: edit-uc-pg-paypal-wpp-enabled
But i see no action if i disable it.

What exactly is this checkbox for - shouldn't we disable the whole express thing if we disable the gateway?

CommentFileSizeAuthor
#2 391936.uc_paypal_ec_disable.2.x.patch438 bytescha0s
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Assigned: Unassigned » rszrama

Hmm... I guess really I'm just not sure that "enabled/disabled" checkbox should be there at all. However, in the short term, I think you're right. The feature request would be to check that box's value before displaying the PayPal EC stuff if possible.

cha0s’s picture

cha0s CreditAttribution: cha0s commented
Status: Active » Needs review
FileSize
391936.uc_paypal_ec_disable.2.x.patch438 bytes

Is this all we need to do?

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Status: Needs review » Active

I don't think so, because now you can have WPP enabled by EC disabled and it will pass.

cha0s’s picture

cha0s CreditAttribution: cha0s commented

uc_cap_uc_paypal_ec_enabled doesn't appear to be used anywhere else in the code.

cha0s’s picture

cha0s CreditAttribution: cha0s commented

Can we get a review on this so we can get it fixed up and closed?

rszrama’s picture

rszrama CreditAttribution: rszrama commented
Assigned: rszrama » Unassigned
Category: bug » feature
Status: Active » Closed (won't fix)

That variable is constructed by the cart pane settings form. I reviewed this issue and I'm going to mark it won't fix. The reason is this: using PayPal WPP as a payment gateway plugged into the credit card payment method is different than enabling the PayPal EC alternate checkout payment method. It's quite feasible for someone to use Auth.Net for CC processing and still allow users to shortcut the process using PayPal EC (or Google Checkout for that matter). The user should be able to disable WPP as a credit card payment gateway but still keep the PayPal EC payment method available. The main issue here isn't the payment gateway checkbox, it's the single-modular nature of the PayPal module.