add drupalGetTestFile method to drupal_web_test_case [#391210]

while working on #389040: fix bug in UserPictureTestCase::testWithGDinvalidSize, i noticed it was hard to just get a file bigger than a given size.

talked to boombatower about this in #drupal, here's a patch that adds this.

Comment	File	Size	Author
	drupalGetTestFile.patch	8.69 KB	Anonymous (not verified)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 March 2009 at 20:20

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

c960657 CreditAttribution: c960657 commented 4 March 2009 at 20:39

I think drupalGetTestFile() and drupalGetTestFiles() should take the same parameters, so the former can be a simple wrapper around the latter. Perhaps drupalGetTestFiles() could take an additional $count parameter.

I don't know why the existing implementation uses stat() rather than filesize(). Using filesize() seems like the obvious choice.

For now, positional parameters is probably fine, but it may be an idea to array-itize the parameters (like it was done in #255551: DX: Array-itize file_scan_directory()'s parameters).