while working on #389040: fix bug in UserPictureTestCase::testWithGDinvalidSize, i noticed it was hard to just get a file bigger than a given size.

talked to boombatower about this in #drupal, here's a patch that adds this.

drupalGetTestFile.patch8.69 KBbeejeebus
Failed: 10384 passes, 43 fails, 62 exceptions View
Members fund testing for the Drupal project. Drupal Association Learn more


Status: Needs review » Needs work

The last submitted patch failed testing.

c960657’s picture

I think drupalGetTestFile() and drupalGetTestFiles() should take the same parameters, so the former can be a simple wrapper around the latter. Perhaps drupalGetTestFiles() could take an additional $count parameter.

I don't know why the existing implementation uses stat() rather than filesize(). Using filesize() seems like the obvious choice.

For now, positional parameters is probably fine, but it may be an idea to array-itize the parameters (like it was done in #255551: DX: Array-itize file_scan_directory()'s parameters).

boombatower’s picture

I might just replace drupalGetTestFiles().

hass’s picture


boombatower’s picture

Project: Drupal core » SimpleTest
Version: 7.x-dev » 7.x-2.x-dev
Component: simpletest.module » Code
beejeebus’s picture

Assigned: beejeebus » Unassigned