Forum icon does not display as locked (aka closed) if comments are "disabled" instead of "read only"

sorry if the patch doesn't apply automatically properly -- I edited out the irrelevant parts of a much larger diff and saved that edit job as this patch file.

What does that mean? I'm pretty unfamiliar with the codebase.

My one guess is that you mean it should be using these defined constants instead of 0 and 1:

/**
 * Constants to define a node's comment state
 */
define('COMMENT_NODE_DISABLED', 0);
define('COMMENT_NODE_READ_ONLY', 1);
define('COMMENT_NODE_READ_WRITE', 2);

Patch applied to do that. Uses defined() to test if COMMENT_NODE_DISABLED has been set.

Thanks for the pointer on process.

I believe that the constant should be checked for, but anyway here's another patch without the check. I changed '==' to '===' to try to help mitigate this extra assumption.

Oops, I thought I had tested the === condition, but it was actually a cached page I was looking at (drupal's caching behavior still confuses me a bit).

This time it works.

so is this code okay?