Update garland to support popbox [#387156]

This patch depends on #374646: Popbox (Popups Lite): Adding Modal Dialogs to Confirmations. It updates garland to support the popbox effect, but adding id's to the page title and page content area in page.tpl.php. This brings garland in line with the newly polished default page.tpl.php.

Also, this patch demonstrates customizing the look of the popbox dialog in a theme, by modifying the style.css and adding popbox.js file.

Comment	File	Size	Author
#4	popbox-garland.patch	3.78 KB	starbow
#4
#3	garland-popbox.png	27.26 KB	starbow
#2	garland-popbox.png	27.26 KB	starbow
	popbox-garland.patch	2.96 KB	starbow

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

1 March 2009 at 02:50

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

starbow CreditAttribution: starbow commented 1 March 2009 at 06:21

File	Size
garland-popbox.png	27.26 KB

Here is a screenshot (while I am hunting down the failed tests).

Comment #3

starbow CreditAttribution: starbow commented 1 March 2009 at 08:43

Status:

Needs work

» Needs review

File	Size
garland-popbox.png	27.26 KB

And here it is again, with a change to the test to accept the new id.

Comment #4

starbow CreditAttribution: starbow commented 1 March 2009 at 08:45

File	Size
popbox-garland.patch	3.78 KB

No, no, the patch you fool :)

Comment #5

RobLoach

he/him

CreditAttribution: RobLoach commented 1 March 2009 at 23:36

Status:

Needs review

» Needs work

I think we should provide a close icon in the CSS instead of the Drupal.t('X').

Comment #6

starbow CreditAttribution: starbow commented 2 March 2009 at 03:28

I agree. I just threw the X in there to make sure it was working.
Last year I used the misc/watchdog-error.png as a close image, but it was universally rejected. Drupal could really use a set of utility icons. Not sure if this patch is the place to introduce them though.

Comment #7

alexanderpas CreditAttribution: alexanderpas commented 22 May 2009 at 05:07

actually, i think we should do Drupal.t('close'), a close icon can always be done trough CSS, and some themes might want to show both text and icon (which is easy, since we have an id'ed <div> and an <a> to work with).