With the updates made to the new page tpl code: http://drupal.org/node/367299 it became clear to me that some things needed to be moved, specifically $messages and $breadcrumb. Currently these reside in the main content area, i.e. above $content, within the same containing div. There've been a number of different conversations on moving these, ultimately we decided to not hash it out in favor of getting our new html into core more quickly, however I feel very strongly that we should move $messages and $breadcrumb to but within their own (individual) divs under the current navigation, above the main-wrapper. It makes little or no sense to separate the title from the content with these items, and I personally believe this is a remnant of the garland theme. I'm not sure how else it's embedded itself into our default output.
Garland is actually rather unique in the ways and reasons it does certain things. For the stylized approach garland takes it makes perfect sense to place these items within the content area, the breadcrumb is limited in size by the content area, there's no other place for messages but the content area... this is NOT the normal for designs, and as such I really feel we need to say "This is a garland specific setting, and it's great for garland, but our default html doesn't need to work this way.".
Content area currently restricts the size of the messages. These could be larger and draw more attention to themselves than they do currently if they were taken out of the content area. This would result (imo) in greater visibility.
Breadcrumbs are really their own thing as well and should be visually separated from content. They're closer in relation to navigation than anything else, and again I really think we should move all of these out of the content area.
Eclipse
Comment | File | Size | Author |
---|---|---|---|
#14 | move_breadcrumb_messages_v1.patch | 1.27 KB | Jeff Burnz |
#13 | highlight_in_content.png | 152.13 KB | Jeff Burnz |
#10 | admin-modules.png | 140.63 KB | Jeff Burnz |
#6 | Picture 2.png | 78.47 KB | EclipseGc |
#4 | Picture 1.png | 59.95 KB | EclipseGc |
Comments
Comment #1
wretched sinner - saved by grace CreditAttribution: wretched sinner - saved by grace commentedComment #2
geerlingguy CreditAttribution: geerlingguy commentedDo you think we should put them into their own div, on the same level as header and main?
Comment #3
starbow CreditAttribution: starbow commentedI hope this ends up wrapping the print $messages with a div and an id. Makes it easier to grab them with jQuery and add effects.
Comment #4
EclipseGc CreditAttribution: EclipseGc commentedWebchick asked for a screenshot example. You can see how much more area could easily be devoted to messages, and the breadcrumbs are up with the rest of the navigation (ok, I don't have any in this theme, but you get the idea).
Comment #5
JohnAlbinsubscribe.
Comment #6
EclipseGc CreditAttribution: EclipseGc commentedAs opposed to: (super rough but gets the idea across)
Comment #7
webchicksubscribe.
Comment #8
BrightLoudNoise CreditAttribution: BrightLoudNoise commentedsubscribe
Comment #9
EclipseGc CreditAttribution: EclipseGc commentedAdding tag
Comment #10
Jeff Burnz CreditAttribution: Jeff Burnz commentedJust throwing in another screenshot. The proposal matches how I am doing things these days. From a development theme I am currently working on:
Comment #11
yoroy CreditAttribution: yoroy commentedI'm in favor of this as well. Who'll write the actual patch? :-)
Comment #12
Jeff Burnz CreditAttribution: Jeff Burnz commentedIgnore... sigh, not keeping up with the play here.
Comment #13
Jeff Burnz CreditAttribution: Jeff Burnz commentedIgnore this also, jeff needs a break :/
Comment #14
Jeff Burnz CreditAttribution: Jeff Burnz commentedPatch to get the ball rolling.
Comment #15
yoroy CreditAttribution: yoroy commentedstatus
Comment #16
Dries CreditAttribution: Dries commentedMakes sense to me, and sounds like it could be a small UX improvement. Thoughts?
Comment #17
mortendk CreditAttribution: mortendk commentedit makes a lot of sence to move em
but im only a king so what do i know ;)
Comment #18
catchI usually end up moving these out. Only once a year when I have to do some theming, but still, +1.
Comment #19
bsmirnov CreditAttribution: bsmirnov commentedI agree makes sense.
Comment #20
Jeff Burnz CreditAttribution: Jeff Burnz commentedNote that unlike EclipseGc first screenshot, the patch does not move help, only breadcrumb and messages.
Not sure if we want to move help also, I tend to think this makes sense coming under the title.
Comment #21
yoroy CreditAttribution: yoroy commentedGood to make that point. Let's leave help out of the discussion here and just do what the issue title says:
Move $messages and $breadcrumb out of the content div and into the page div :)
so, RTBC? Patch looks simple enough
Comment #22
Dries CreditAttribution: Dries commentedGreat. Committed to CVS HEAD.
Do we need to update any of the core themes?
Comment #23
Jeff Burnz CreditAttribution: Jeff Burnz commentedThere's only Stark which is covered by this patch, and Garland is best left how it is I would think.
Comment #24
EclipseGc CreditAttribution: EclipseGc commentedI absolutely agree, stark is the only theme that matters here. Garland I think is the culprit who introduced this to begin with, so we're really just cleaning out garland code that should never have been for general consumption.
Eclipse
PS: thx jmburnz for pushing this one through. I got side tracked :-D