Currently the GUI for adding groups or field names contain a prefix. On RTL installs this gets borked - as displayed in the screen shot. The problem is that the english prefix of the field name is on the right, even tough that is in theory a single english "word" (a variable in PHP to be exact).

I attach here a patch which fixes it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elcuco’s picture

elcuco’s picture

Project: » Content Construction Kit (CCK)
Version: » 6.x-2.1
Component: User interface » General

It seems I got the module wrong. I did not find CCK initially. Maybe it's because of migration to D6?

Sorry for the noise.

yched’s picture

Er, I'm not familiar with RTL display and how it should be handled, but I'd naively tend to think that the 'borked' screenshot you provide is the expected behavior ?
At least it's consistent with what I see on core's admin/settings/site-information for the 'Default front page' setting.

I cannot find anything in core similar to the code in the patch, so I'm not sure this is the right approach.

On a related note : care to review #360712: RTL CSS files ?

yhager’s picture

> Er, I'm not familiar with RTL display and how it should be handled, but I'd naively tend to think that the 'borked' screenshot you provide is the expected behavior ?

No, exactly the opposite. Since the field names must be in English, thus LTR, there is no point in putting the prefix to the right of the field name.

> I cannot find anything in core similar to the code in the patch, so I'm not sure this is the right approach.

This is a special case of a field that must be in English, and it should be concatenated to an English string ('field_') - I don't know of anything like it in core, so there's your reason. Setting LTR areas as 'span dir="ltr" is quite a common practice in RTL-land.

elcuco’s picture

Hi yched,

This is simple, and not related to RTL: you are asking for the right part of the english based variable - it should be on the right. Look again at the images, and imagine a variable name on both displays.

borked = bad (in red)
non-borked-patched = good (in green)

yhager’s picture

Status: Needs review » Reviewed & tested by the community

patch applies and works.

yched’s picture

Status: Reviewed & tested by the community » Fixed

Oh, of course, now I get it :-).
Committed. Thanks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.