"Last updated" date in My Tracker does not always get updated when a new comment is added [#377012]

Comment #1

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 19 February 2009 at 16:19

Just want to confirm this weird behaviour of tracker. Exactly as described above.

Log in or register to post comments

Comment #2

tsvenson CreditAttribution: tsvenson commented 19 February 2009 at 17:28

I too can confirm that the same thing happens to me.

Log in or register to post comments

Comment #3

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 19 February 2009 at 17:46

I too have seen this (we probably don't need more confirmation at this point...).

Note that drupal.org uses http://drupal.org/project/tracker2 so this is a bug in that module specifically.

Log in or register to post comments

Comment #4

David Strauss

he/him

CreditAttribution: David Strauss commented 19 February 2009 at 17:47

Subscribing (and attempting to verify).

Log in or register to post comments

Comment #5

David Strauss

he/him

CreditAttribution: David Strauss commented 19 February 2009 at 17:53

I'm wondering if load issues were the cause of this. We're using the exact same indexing code we used before.

Is there a reliable way to reproduce this?

Log in or register to post comments

Comment #6

David Strauss

he/him

CreditAttribution: David Strauss commented 19 February 2009 at 18:03

Another test comment.

Log in or register to post comments

Comment #7

tsvenson CreditAttribution: tsvenson commented 19 February 2009 at 18:03

It seems to me it get stuck in either the last update before the upgrade or the first update/reply after the upgrade. It does update for the first reply/update to new posts/issues, but then no more. At least that is how it seems for my tracker.

Log in or register to post comments

Comment #8

David Strauss

he/him

CreditAttribution: David Strauss commented 19 February 2009 at 18:06

Let's try a new comment with new Tracker 2 code.

Log in or register to post comments

Comment #9

tsvenson CreditAttribution: tsvenson commented 19 February 2009 at 18:08

Quick amendment, for new nodes, with our without existing comments, added to my tracker it only update the time one time.

Also, I tried to edit my previous reply and got "You must enter a project to navigate to." when I tried to save it. Should it be so or is that another bug?

Log in or register to post comments

Comment #10

David Strauss

he/him

CreditAttribution: David Strauss commented 19 February 2009 at 18:09

Assigned:

Unassigned

» David Strauss

I've patched the live code to forward-port the old db_query() method of updating Tracker 2 data. Using drupal_write_record() appeared to fail whenever we were updating Tracker 2 records when someone posted a comment to a node they had already commented on.

Log in or register to post comments

Comment #11

tsvenson CreditAttribution: tsvenson commented 19 February 2009 at 18:09

Assigned:

David Strauss

» Unassigned

Oki, my tracker got properly updated with the new code now.

Log in or register to post comments

Comment #12

David Strauss

he/him

CreditAttribution: David Strauss commented 19 February 2009 at 19:10

Assigned:	Unassigned	» David Strauss
Status:	Active	» Fixed

This has been deployed and fixed in the latest tracker release, though this probably indicates a bug in drupal_write_record().

Log in or register to post comments

Comment #13

David_Rothstein CreditAttribution: David_Rothstein commented 20 February 2009 at 03:36

Project:	Drupal.org infrastructure	» Tracker 2
Version:		» 6.x-1.x-dev
Component:	Other	» Code

Thanks for fixing this!

I looked into where the bug is and I think it was in the previous Tracker 2 code, not drupal_write_record(). The previous code looked like this:

$insert->uid = $uid;
if ($exists) {
  drupal_write_record('tracker2_user', $insert, 'nid');
}
else {
  drupal_write_record('tracker2_user', $insert);
}

The intention of the first drupal_write_record() is to run something like UPDATE {tracker2_user} SET changed = %d, published = %d WHERE nid = %d but because $insert->uid is set, that gets included in the query too, so it tries to update all rows for the node to have the same uid, which of course is wrong (and prevented by the schema)...

So there's probably a way to fix this that continues to use drupal_write_record() in most places. I'll roll a patch if you want, although given that it's working now, maybe it's best to leave well enough alone :)

Log in or register to post comments

Comment #14

David Strauss

he/him

CreditAttribution: David Strauss commented 20 February 2009 at 19:10

Thanks, David. I'm not inclined to move this back to drupal_write_record(). The abstraction it provides is not amazing for Tracker 2 (we're not dynamically changing the queries), and it will only slow down, having to look up schema data to generate the queries.