Filter comments by comment depth [#373601]

I would like to be able to filter comments by comment depth. Comment depth is available for sort as well as a field, but not as a filter. I've attached a patch which accomplishes this, however the SQL it uses may not be compatible with systems other than MySQL. This is why it needs review. The SQL in question is:

    $field = "(LENGTH(" . 
             $this->table_alias . 
             ".thread) - LENGTH(REPLACE(" .
             $this->table_alias . 
             ".thread, '.', '')))";

which results in SQL like:

(LENGTH(comment.thread) - LENGTH(REPLACE(comment.thread, '.', '')))

This unfortunately cumbersome SQL counts the number of periods in the comment.thread field by subtracting the length of the field with periods replaced from the length of the full field. If this can be done with PHP here instead, or some more database-neutral way, I strongly suggest that be done.

Comment	File	Size	Author
#4	views-6.x-3.0-rc1.comment-depth-filter.patch	1.71 KB	vidorado
#4
	views-add-filter-comment-depth.patch	2.25 KB	msielski

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

msielski

he/him

CreditAttribution: msielski commented 12 February 2009 at 21:25

If you apply this patch be sure to clear your views cache so you can see the new filter option.

Comment #2

himerus CreditAttribution: himerus commented 9 April 2010 at 23:15

Did you ever get further with this? or a better alternative?

I'm currently trying to implement this via a custom handler in my own module rather than patching.

Comment #3

esmerel CreditAttribution: esmerel commented 18 August 2010 at 21:58

Status:

Needs work

» Closed (won't fix)

No work on patch in more than 3 months

Comment #4

vidorado CreditAttribution: vidorado commented 9 November 2011 at 14:50

Status:

Closed (won't fix)

» Needs review

File	Size
views-6.x-3.0-rc1.comment-depth-filter.patch	1.71 KB

I've found a better alternative than the original patch, modifying only the views module instead of modifying both views and comment modules (hacking a module is bad, but i think that hacking the core is very bad...).

I don't know yet how to make CVS compatible patches from GIT, so my patch won't pass the automatic test, but it works. It's tested with views-6.x-3.0-rc1

Hope that helps (and it would be wonderful if merlinofchaos could commit it to the dev branch so we don't get crazy with our future updates of views).