drupal_write_record() returns FALSE on insert when table has multi-field primary key [#369423]

drupal_write_record() tests for a last insert ID and returns FALSE if none is found. However, it appears that this ID is returned only for single-field primary key tables. If there is a multi-field primary key, no insert ID is returned and drupal_write_record() returns FALSE instead of the correct value of SAVED_NEW or SAVED_UPDATED.

Patch ensures FALSE is returned only if there is a single-field primary key.

Comment	File	Size	Author
#6	drupal_write_record-multi-key-plus-tests.patch	3.35 KB	nedjo
#6
#4	drupal_write_record-tests.patch	2.78 KB	nedjo
#4
	drupal_write_record-multi-key.patch	595 bytes	nedjo

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

nedjo

he/him/his

English

CreditAttribution: nedjo commented 5 February 2009 at 02:46

Status:

Active

» Needs review

I'm going to include this patch also in #361597: CRUD API for locale source and locale target strings because without it a test there fails.

Comment #2

Dries CreditAttribution: Dries commented 5 February 2009 at 12:31

Looks good -- would be better if it came with some tests. :)

Comment #3

nedjo

he/him/his

English

CreditAttribution: nedjo commented 5 February 2009 at 22:36

Here is a basic set of tests on drupal_write_record(). They could be extended but I'd rather do that as part of #365899: API methods for schema-based load and delete operations.

With this test patch, two tests should fail, for the return values from drupal_write_record() on insert and update for tables with multi-field primary keys. With drupal_write_record-multi-key.patch these tests will pass.