Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.My emails are showing up blank. I know there was a bug for 6.x-2.x but I'm seeing this issue on 5.x.
I'm having a problem applying this patch to 5.x-2.3. I do not have the line of code to change in webform.module.
Am I missing something?
Change line 1733 from:
$messages[$cid] = theme(array('webform_mail_'. $node->nid, 'webform_mail'), $form_state['values'], $node, $sid, $cid);
to
$messages[$cid] = theme(array('webform_mail_'. $node->nid, 'webform_mail', 'webform_mail_message'), $form_state['values'], $node, $sid, $cid);
Thanks-
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | email.JPG | 22.35 KB | ctrlchar |
| #10 | file.JPG | 62.01 KB | ctrlchar |
| #10 | textarea.JPG | 54.54 KB | ctrlchar |
| #10 | textfield.JPG | 46.8 KB | ctrlchar |
| #8 | form_components_screen.JPG | 50.69 KB | ctrlchar |
Comments
Comment #1
quicksketchI can't provide support for modified versions of Webform. I'd suggest upgrading to a clean copy.
Comment #2
ctrlchar CreditAttribution: ctrlchar commentedquicksketch,
As far as I know - This is not a modified version.
I attached my webform.module file. This is where the fix above should go, right?
Thanks-
Comment #3
quicksketchMaybe I don't understand what's being asked. Are you asking how to apply a patch or are you providing a patch for a bug in the module? If there's a bug in the module (say in the 2.3 version) that has already been patched (in the 2.4 version), you should upgrade to the new version where that patch has already been applied.
Comment #4
ctrlchar CreditAttribution: ctrlchar commentedMaybe this is more of a question on how to apply the patch and which patch to install for my version.
Do you know where I can find the patch and documentation?
Has this issue been patched in version 2.4?
Thanks-
Comment #5
quicksketchI don't know what patch you're referring to, so I can't say if it's been fixed or not. The change you mention at the top of this issue isn't for Drupal 5 at all, because Drupal 5 doesn't have a $form_state variable. Again, the best advice I can give is upgrade to 2.4 and see if the problem you're having is fixed. If not, then open a bug report describing what the problem is you're experiencing.
Comment #6
ctrlchar CreditAttribution: ctrlchar commentedSorry to bring this back up again. I upgraded to 2.4 and I'm having the same issue. Should I open a bug? if so - where?
Thanks-
Comment #7
quicksketchOkay, now that we're on the same page, we can get to answering your question. :)
I'm not seeing this problem in 2.4. Are you using a custom theme? You might try changing to Blue Marine or Garland, then submit the form and see if the e-mail comes through.
Comment #8
ctrlchar CreditAttribution: ctrlchar commentedI changed the theme to garland and have the same results.
I'm noticing one weird thing; the name doesn't show up on the Form Components edit screen even after adding and saving it. I tried to add another field as a test with the same results. I attached a screen shot of it.
It looks like it has to do with textarea type. File and Textfield works. I've added a test textarea with the same result.
Thanks-
Comment #9
quicksketchCould you take a screenshot of the field configuration page for an individual component? Something is definitely not right here. Webform should be requiring you to enter a label. Does the default value for the label show up in the Label field when edit the component for the second time?
Comment #10
ctrlchar CreditAttribution: ctrlchar commentedwow - I didn't realize you were going reply that quick.
I posted this on my last comment:
It looks like it has to do with textarea type. File and Textfield works. I've added a test textarea with the same result.
Here are the screenshots.
Thanks-
Comment #11
quicksketchIn all three of the screenshots above the "Label" field is not filled out, yet it is required. Is Webform not saving the value of the label? There's also something funny with the form in that the "Label" field should be above "Default value". When you say "File and Textfield works." does that mean that file and textfields are coming through in the e-mail or something else?
Comment #12
ctrlchar CreditAttribution: ctrlchar commentedyes - the label values are not being saved.
Here's a screen shot of the mail coming through.
Everything other than textfield comes through.
Comment #13
quicksketchWell this isn't going to be a tremendous help, but I think some other module on your site is modifying Webform's form for editing components. In a clean Drupal install, I'm not seeing this sort of behavior. Try disabling modules on your site until Webform is able to save labels properly.
Comment #14
quicksketch