Problem/Motivation

Regularly the slowest functional js test.

158.700s Drupal\Tests\ckeditor5\FunctionalJavascript\MediaTest                     8 passed

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613246

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16444

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems like a good split.

Curious what the threshold is for cspell words. Meaning since they appear in 2 files now should they move to dictionary or does it need to be more? Just a random Sunday thought not worth holding an issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Re cspell it doesn't really matter.. we are (slowly) cleaning it all up, as long as we don't make things significantly worse it doesn't make any difference.

Committed and pushed e896eca4e67 to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed e896eca4 on main 
    test: #3613246 Split up ckeditor5's MediaTest

By: catch
By: smustgrave