Problem/Motivation

For every package manager operation, it first calls composer multiple times to ensure that:

- composer exists
- that the executable is actually composer
- that the composer version is correct

This can add seconds before anything actually gets called.

I think we could consider moving these checks to the automatic updates and project browser modules, and they could run them before undertaking series of operations and potentially cache the check for an hour or so. If composer is valid, it's not going to become invalid again a few seconds later.

Noticed this when profiling package_manager tests, but it's a runtime performance issue in package manager.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3613200

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Issue summary: View changes
catch’s picture

Status: Active » Needs review

Test failures show that we don't explicitly validate before creating a sandbox, so added explicit validation there.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

catch’s picture

Status: Needs work » Needs review

Rebased.