Closed (fixed)
Project:
Advanced Text Formatter
Version:
4.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Jun 2026 at 07:12 UTC
Updated:
15 Jul 2026 at 09:30 UTC
Jump to comment: Most recent
Comments
Comment #3
akshay kashyap commentedI tested this MR locally on a clean Drupal installation and went through all of the scenarios covered by the new kernel test.
I also verified the formatter manually with different settings, including:
In each case, the rendered output matched the expected result, and the new kernel test passed successfully.
I also ran the module's test suite after applying the MR and didn't encounter any regressions or unexpected failures.
Overall, this is a nice improvement. The data provider makes the test easy to read and extend, and it provides good coverage for the formatter's core functionality. This should help catch regressions if changes are made to the formatter in the future.
I only have a couple of minor suggestions:
: voidfor the test method and: arrayfor the data provider) to keep the test consistent with current Drupal coding standards.Other than those minor suggestions, the implementation looks good to me, and all the scenarios I tested locally are working as expected.
Comment #4
akshay kashyap commentedComment #6
igor mashevskyi commented