Problem/Motivation

We are seeing this warning message when displaying maps:

Warning: Undefined array key "label" in Drupal\leaflet_views\Plugin\views\style\LeafletMap::getLeafletMaps() (line 30 of modules/contrib/leaflet/src/LeafletSettingsElementsTrait.php).

Proposed resolution

Set null as a the fallback value.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 leaflet-prevent_undefined_array_key-3605769-5.patch504 bytesitamair
#4 leaflet-prevent_undefined_array_key-3605769-4.patch504 bytesliam morland

Issue fork leaflet-3605769

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !76

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new leaflet-prevent_undefined_array_key-3605769-4.patch504 bytes

Current state of merge request.

itamair’s picture

itamair commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new leaflet-prevent_undefined_array_key-3605769-5.patch504 bytes

thanks @liam for rising this up.
This use case might happen when the "'label" property is not defined in the hook_leaflet_map_info().
But in that case better rather than NULL better set the $options[$key] value as the $key itself.

Updated patch attached ...

  • itamair committed 98bb4e22 on 10.4.x 
    fix: #3605769 Prevent "Undefined array key" warning in...
itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Fixed

patch #5 committed into 10.4.x branch, will be part of the next Leaflet 10.4.10 release.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland closed merge request !76

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.