Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Not sure why taxonomy being an optional module is installed in system.install rather than in taxonomy.install.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | taxonomy_install.patch | 1.46 KB | agentrickard |
| taxonomy_uninstall.patch | 1.46 KB | drewish | |
Comments
Comment #1
Dave ReidSubscribing for later review.
Comment #3
catchComment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedThis patch functions as described.
Comment #5
agentrickardVery minor re-roll, since #360106: Allow comment to be uninstalled - move install/uninstall from system.install to comment.install has been committed.
This is probably RTBC.
Comment #6
agentrickardIn theory, both patches should be backported to D6.
Comment #7
webchickCommitted this to HEAD as well. Thanks!
I'm not sure about a back-port. Currently, 6.x contributed modules can always count on the taxonomy and comment tables being present in Drupal's schema. This changes as a result of this patch. Seems like it might cause module breakage in a minor release, and it's not really hurting anything in those old sites to have the tables there.
Comment #8
agentrickardAcceptable to me. Nix the backport.
Comment #9
catchNo time right now but we should open up issues for removing taxonomy + comment variables as well now the basics are in.
Comment #10
agentrickard@catch, that should be part of the larger #145164: DX: Use hook_variable_info to declare variables and defaults fix, so effort should go over there.