Closed (won't fix)
Project:
Voting API
Version:
6.x-2.3
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2009 at 03:32 UTC
Updated:
7 Dec 2017 at 08:41 UTC
Jump to comment: Most recent, Most recent file











Comments
Comment #1
linksunten CreditAttribution: linksunten commentedThis version of comment_moderation should work together with comment_mover...
http://drupal.org/node/360095#comment-1205288
...and with hidden:
http://drupal.org/node/359074
Comment #2
eaton CreditAttribution: eaton commentedThere's a problem with this approach, unfortunately: without the IP checking, anonymous voting wouldn't really be possible. Also, have you considered posting the comment moderation as a standalone module? VotingAPI itself doesn't implement any user-facing voting widgets; it's just about managing the data.
I'm going to be postponing this one until the 2.1 release; there are still some questions that need to be ironed out, IMO.
Comment #3
linksunten CreditAttribution: linksunten commentedYes, you are right, that's why we made the IP checking optional. We don't want to store any IP adresses but if someone wishes to: it's still the default.
We are not going to release the comment moderation module since CitizenKane will. He started the project, we just enhanced his code and made it work.
Comment #4
bacchus101 CreditAttribution: bacchus101 commentedI'd love to see where this goes as this is exactly the kind of functionality I would like to see moving forward with comments and the voting api.
Comment #5
linksunten CreditAttribution: linksunten commentedSorry we don't have time for this module at the moment. Attached is the current version we are using at http://linksunten.indymedia.org
You might want to have a look at http://lists.indymedia.org/pipermail/imc-drupal-dev/2009-March/0305-18.html and http://linksunten.indymedia.org/en/node/770
IMC linksunten
Comment #6
bacchus101 CreditAttribution: bacchus101 commentedThanks. I appreciate it.
Comment #7
anarcat CreditAttribution: anarcat commentedSeems to me this would be a good feature. The idea here is to avoid logging IPs when we don't *need* to. I think the patch doesn't quite do that: it's really a kill switch that *will* break anonymous user voting in its current state. Also, I don't quite understand the reason behind the first chunk of the patch.
I think that if the setting really applies to only anonymous users, there's no reason why it shouldn't get in.
Comment #8
linksunten CreditAttribution: linksunten commentedThe first part is not necessary anymore. We are using the attached two patches with version 2.3 of VotingAPI. We really don't want to log IP addresses and I don't see any reason why we should not be allowed to turn the logging off.
Comment #9
Scott Reynolds CreditAttribution: Scott Reynolds commentedI missed the boat here but why is logging IP addresses a problem?
Comment #10
linksunten CreditAttribution: linksunten commentedBecause it compromises anonymity. We do not want to log IP addresses so that our authors are protected in case of infiltration or in case of a server seizure.
Comment #11
Scott Reynolds CreditAttribution: Scott Reynolds commentedOk, well then I would change the name of the variable. Its abbreviated nonsense now. maybe something like 'votingapi_obsecure_ip'. The default value for the variable should be FALSE not TRUE.
Comment #12
linksunten CreditAttribution: linksunten commentedChanged title
Comment #13
legolasboDrupal 6 is no longer supported. Closing old issues to clean up the issue queue.
Please reopen and update this issue if this is still an issue in the D7 or D8 version.