Problem/Motivation

After upgrading to Editoria11y 3.x, I am now seeing "Link points to a file without warning" alerts on pages that contain links to PDFs. I already use CSS to automatically append icons next to these links, so this alert is unnecessary.

The alert appears only when the CSA module is uninstalled, even if the "Modify tests that usually detect content issues" → "Links" → "Link points to a file without warning" (LINK_FILE_EXT) option within the Editoria11y settings form is unchecked and disabled.

Steps to reproduce

  1. Install Editoria11y 3.0.2 from scratch, or upgrade from 2.x
  2. Do not install the Editoria11y CSA submodule
  3. On the module's settings form, you can confirm that "Link points to a file without warning" is unchecked and disabled by default
  4. Create a link to a PDF (or other document) within an Editoria11y-scanned page
  5. The "Link points to a file without warning" message will appear on the page's accessibility alerts

The alert will correctly not trigger if you enable the CSA submodule and change the LINK_FILE_EXT setting to "Off". But it will display again if you then uninstall the CSA submodule.

Environment details for bug reports
  • Drupal version: 10.6.8
  • CSA submodule installed: N
  • Exports submodule installed: N
  • Site URL: https://wildlifecenter.org (testing on local dev site)

Comments

noahterp created an issue. See original summary.

itmaybejj’s picture

itmaybejj commented
Assigned: Unassigned » itmaybejj

I'll get this fixed.

Part of the issue is that the PDF image is not contributing to the accessible name of the link on your site; that test auto-suppresses if it finds various words in the title or ARIA description, which is provided by modules like Link Purpose.

Note that CSS only solutions like yours can use CSS alt text (content: "" / " PDF"), but you'll get a false positive if you do since we haven't implemented that branch of the accessible name calculation yet. I haven't encountered it in the wild yet.

itmaybejj’s picture

itmaybejj commented
Issue summary: View changes
noahterp’s picture

noahterp commented

Thanks for the update! I assumed it was just a small logic check bug that ran this test even though it was disabled.

I actually have some content alt text already coded locally in the theme CSS files (including those document icons). Just need to run some more tests, and I'll push that live soon.

itmaybejj’s picture

itmaybejj commented

Fair enough. I'll fix the config problem that prevents this from disabling, and show this around as the moment we've been waiting for when we need to figure out how to parse these pseudo-content strings.

  • itmaybejj committed d1688e16 on 3.0.x-dev 
    fix: #3589579 Cannot disable Link points to a file without warning alert...

  • itmaybejj committed 3bf76f89 on 3.0.x 
    fix: #3589579 Cannot disable "Link points to a file without warning"...
itmaybejj’s picture

itmaybejj commented
Status: Active » Fixed

Well this didn't turn out to be a typo at all, but rather the result of a need to better mediate a 4-way argument between library default config, base module default config, CSA module default config, and the JS config translation layer.

3.0.3 tagged and released. If you want a bug bounty credit for a year of CSA just ask.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • itmaybejj committed 3bf76f89 on 3.0.x-dev 
    fix: #3589579 Cannot disable "Link points to a file without warning"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.