Add third party settings config dynamically

Hi,

Thanks for your appreciation on UI Suite :)

Thanks to have created this issue. I am aware of it and thinking about it as a background task.

Like you found out, the problem is that ui_styles_entity_status and ui_styles_page store config into the theme config and their hook_config_schema_alter is active of course only when the modules are enabled.

I need to check if a theme can implements hook module enabled. If yes, move the config from config/install to this hook.

Otherwise, maybe implements this hook into the ui_suite_bootstrap_companion submodule which is intended for stuff not possible to do/to override with a theme.

So I checked, themes cannot implements hook_modules_installed and hook_themes_installed.

So in ui_suite_bootstrap_companion, there could be both hooks:

  /**
   * Implements hook_modules_installed().
   */
  #[Hook('modules_installed')]
  public function modulesInstalled($modules, bool $is_syncing): void {
    if ($is_syncing) {
      return;
    }


  }

  /**
   * Implements hook_themes_installed().
   */
  #[Hook('themes_installed')]
  public function themesInstalled($theme_list): void {
    if (\Drupal::service('config.installer')->isSyncing()) {
      return;
    }

  }

hook_modules_installed:
- when enabling ui_styles_entity_status, loop on ui_suite_bootstrap and its children themes to add the config.
- when enabling ui_styles_page, loop on ui_suite_bootstrap and its children themes (or only on ui_suite_bootstrap) to add the config. if the theme as the sidebar_first and sidebar_second regions.

hook_themes_installed:
- if the installed theme is a subtheme of ui_suite_bootstrap and the ui_styles_entity_status or ui_styles_page are already enabled, add the config.

Hi,

Thanks for the MR, very nice start.

The other parts of comment 5 needs to be implemented as well.

Hi, I noticed the same while running config_inspector on a project.

I think using theme_settings's third_party_settings in ui_styles_page and ui_styles_entity_status would have been ideal for this (no hook_config_schema_info_alter in those modules, no hook_modules_installed needed in UISB). But maybe that is too disruptive? OTOH I don't see other contribs using them:
- https://search.tresbien.tech/search?q=ui_styles_entity_status_unpublishe...
- https://search.tresbien.tech/search?q=ui_styles_regions&num=50&ctx=0

Hum, I don't know why I didn't save those settings in third_party_settings from the beginning.

If theme settings can have third party settings, this is definitely the way to go.

Then changes needs to be done in ui_styles_page and ui_styles_entity_status then we can update in the ui_suite_bootstrap theme.

Thanks @herved for pointing that!

PS: And I think I have the CSS variables from ui_skins in this case too...

I have created the issues in UI Styles and UI Skins.

I think hook_modules_installed is still needed in UISB because even if now placed in third_party_settings, the schema will not be detected without the modules.

Waiting for UI Styles 8.x-1.20 to be released to merge.