Problem/Motivation

This issue is a follow-up to #3574717: Remove deprecated code from migrate module, where (among other things) the deprecation message is removed.

Currently, the deprecation message for Drupal\migrate\Plugin::getMigrationDependencies() is

'Calling ' . __METHOD__ . ' with the $expand parameter is deprecated in drupal:11.0.0 and is removed drupal:12.0.0. See https://www.drupal.org/node/3442785'

That suggests that something bad will happen if the parameter is passed after Drupal 12.0.0. In fact, any extra parameters are ignored.

Proposed resolution

Change the deprecation message to

'Calling ' . __METHOD__ . ' with the $expand parameter is deprecated in drupal:11.0.0 and has no effect in drupal:12.0.0. See https://www.drupal.org/node/3442785'

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3582125

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benjifisher created an issue. See original summary.

benjifisher opened merge request !15271

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Assigned: benjifisher » Unassigned
Status: Active » Needs review

I made the proposed change.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward. There are no tests around this deprecation so I highly doubt this change caused any test failure. Didn't even both starting a new pipeline.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Title: Improve the deprecation in getMigrationDependencies() » Improve the deprecation message in getMigrationDependencies()

godotislate closed merge request !15271

godotislate’s picture

godotislate
he/him
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed de586af and pushed to 11.x and committed f7a19ff and pushed to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.