Problem/Motivation

The \Drupal\node_revision_delete\Plugin\QueueWorker\NodeRevisionDelete class has a number of performance problems. It loads all revisions for an entity but if you're looking to use this module you probably have a lot of revisions.

Proposed resolution

  • Re architect the queue processor and plugins to use entity queries where possible so that we're not loading revisions all the time.
  • If we are deleting more than 50 revisions (should be configurable) then we should requeue the item.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork node_revision_delete-3581256

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !55

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 2.0.x-dev » 2.1.x-dev

  • alexpott committed bf249470 on 2.1.x 
    perf: #3581256 Performance: do not load revisions unless you have to

By...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.