Problem/Motivation

This problem popped up when upgrading to the latest version of Drupal Canvas (which uses a Decorator class).

More info on the initial issue: https://www.drupal.org/project/canvas/issues/3580632

Steps to reproduce

Render a block from an SDC in drupal canvas

for example:

{{ drupal_block('webform_block', {webform_id: webform, lazy: true}) }}

Proposed resolution

protected $pluginManagerBlock;

Swap

\Drupal\Core\Cache\CacheableDependencyInterface

For

\Drupal\Core\Block\BlockManagerInterface

Issue fork twig_tweak-3580906

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

f0ns created an issue. See original summary.

f0ns opened merge request !78

f0ns’s picture

f0ns commented

Pushed the changes that fix this.

f0ns’s picture

f0ns commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 3.4.1 » 3.x-dev
Status: Needs review » Reviewed & tested by the community

Thanks @f0ns - totally makes sense, thanks!

f0ns’s picture

f0ns commented

Thank you for reviewing!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thanks @f0ns - merged! Please try latest dev!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

FYI: In 4.x this was already fixed.

f0ns’s picture

f0ns commented

Thank you, I wasn't even aware there was a 4.x branch.

I was going to ask to set it as active but I noticed there is already an issue for that: https://www.drupal.org/project/twig_tweak/issues/3581450

Thanks! 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

@grevil: I just saw we have no tagged release yet for this major bugfix! Could you please tag one and also publish a 4.x release? Thanks!

f0ns’s picture

f0ns commented

Thanks, for adding this in the new release.

Fixed!