Problem/Motivation

PHP 8.5 deprecates non-canonical cast aliases. (boolean) must be replaced with (bool).

In sitemap.install, line 47 uses (boolean) which triggers a deprecation warning at parse time:

Deprecated function: Non-canonical cast (boolean) is deprecated, use the (bool) cast instead

Proposed resolution

Use the (bool) cast instead

Remaining tasks

  1. Write a merge request - merge request !60 created by @mably in #2
  2. Community review - done by @nicrodgers in #4
  3. Maintainer review - done by @mparker17 in #5
  4. Commit - done by @mparker17 in #7
  5. Release - released by @mparker17 in 8.x-2.6

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Issue fork sitemap-3578837

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !60

mably’s picture

mably commented
Status: Active » Needs review
nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
commented
Status: Needs review » Reviewed & tested by the community

Code change looks good and fixes the problem for me, thanks @mably :)

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

@mably thank you very much for the patch!

@nicrodgers, thank you for the community review!

I've taken a look at the code, and it looks good.

I'll update the contribution record, and then merge.

Thanks!

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Updating the issue summary to follow the template.

  • mparker17 committed 6cd2e16d on 8.x-2.x authored by mably 
    task: #3578837 Replace deprecated (boolean) cast with (bool) for PHP 8.5...
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Merged! I will update this issue when this change is released.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

The changes in this issue have been released in sitemap-8.x-2.6.

Thanks everyone!

mably’s picture

mably commented

Thanks @mparker17!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.