Problem/Motivation

The final version of Editoria11y 3.x modified some of its exposed methods to reduce race conditions and prepare for Sa11y adopting its State pattern.

Proposed resolution

  • References to Ed11y.checkAll() should be changed to Ed11y.refresh(), which is a debounced version that prevents race conditions.
  • Some manual calls to refresh() may no longer needed, as the updates fixed some bugs with DOM mutation observing.
  • Some references to Ed11y.State need to be changed to Ed11y. UI.

Remaining tasks

I'll send a MR.

Issue fork ai_editoria11y-3573439

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

itmaybejj created an issue. See original summary.

joevagyok’s picture

joevagyok commented

Thank you for writing up these points! If you wish to do these changes, I will wait for the MR to review. Much apprechiated!

itmaybejj opened merge request !6

itmaybejj’s picture

itmaybejj commented

I also suggest switching the button placement; I divided that bottom bar. I'll add a commit for that.

joevagyok’s picture

joevagyok commented

Thank you for the MR!

joevagyok’s picture

joevagyok commented
Status: Active » Reviewed & tested by the community

joevagyok’s picture

joevagyok commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.