Problem/Motivation

The Express Checkout buttons support several options, to modify its appearance. The most interesting missing feature are the Layout options. (Also button themes for paypal and klarna would be nice)

Steps to reproduce

Proposed resolution

Create settings to modify the express checkout buttons "layout" object and add paypal and klarna button theme settings.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

grevil created an issue. See original summary.

grevil’s picture

Status: Active » Needs review

Alright, that should be it, I already did some manual testing but I will go through all the new settings tommorow.

anybody’s picture

Definitely a very helpful addition, thanks @grevil! Let's see what the maintainers think about it. Maybe you could add a screenshot to show why this is needed for better checkout UX?

grevil’s picture

New PayPal and Klarna Styling Options in Action:
screenshot

Overflow set to never (disables the dropdown, all buttons shown):
screenshot2

The new fieldset inside the express checkout configuration:
screenshot3

(Note, that the site is in german. Some of the strings are translated)

Tested manually, everything works as expected. Ready for final review!

anybody’s picture

Status: Needs review » Reviewed & tested by the community

Whao, nice work @grevil that was fast!! Works great and adds the missing features perfectly!

grevil’s picture

StatusFileSize
new9.63 KB

Static patch for the time being.

grevil’s picture

Sorry, one minor adjustment.

grevil’s picture

StatusFileSize
new9.79 KB

New static patch.

anybody’s picture

Just wanted to confirm that this works GREAT and is a wonderful improvement. Re-confirming RTBC.

anybody’s picture

Re-confirming RTBC. We're using this in production happily since >3 months now.