Please don't pick up multiple ones, want to give everyone a chance

Problem/Motivation

Remove all D12 deprecated code from the mentioned libraries.

Steps to reproduce

Proposed resolution

Remove all D12 deprecated code from the mentioned libraries.

Remaining tasks

Make sure tests are passing before review.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3571068

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

Title: Remove deprecated code from lib/File and lib/FileTransfer » Remove deprecated code from lib/File
Status: Active » Postponed

FileTransfer overlapped with one dww is working on so rescoping.

smustgrave’s picture

Status: Postponed » Active
smustgrave’s picture

Title: Remove deprecated code from lib/File » Remove deprecated code from lib/File + lib/Form
smustgrave’s picture

Assigned: Unassigned » smustgrave

Been a few weeks so going to pick it up and expand the scope

smustgrave’s picture

Status: Active » Postponed

Found an issue so this is postponed on #3574721: FormBuilder service order causes failure

smustgrave’s picture

Title: Remove deprecated code from lib/File + lib/Form » Remove deprecated code from lib/Extension, lib/Form, some left over in other folders
Status: Postponed » Needs work
smustgrave’s picture

Status: Needs work » Needs review

This should be a good chunk. Avoiding the test folders in lib for #3550268: Remove deprecated paths from the testing framework

dcam’s picture

Status: Needs review » Needs work

I left comments on the MR. At least some of these need to be changed, so I'm setting the status to Needs Work.

smustgrave’s picture

Status: Needs work » Needs review

Attempted to address feedback. Believe nightwatch is random but can't rerun

dcam’s picture

Status: Needs review » Needs work

Thank you, @smustgrave. I left a couple of additional comments that I think need to be addressed.

smustgrave’s picture

Status: Needs work » Needs review

Added the test

dcam’s picture

Status: Needs review » Reviewed & tested by the community

I think we're done here. Thank you for working with me on it, @smustgrave.

berdir’s picture

This has some removals in the Plugin namespace but not \Drupal\Core\Plugin\DefaultPluginManager::__construct(), but I guess it's OK to separate that out specifically because I'm not 100% sure about really going through with that in D12 (it's a disruptive, non-trivial removal affecting a ton of projects that doesn't have tooling yet). Lets open a separate issue to discuss that further?

catch’s picture

Status: Reviewed & tested by the community » Fixed

Yeah let's open a dedicated issue for DefaultPluginManager::__construct() we can always defer that one to removal in 13.x if we think it'll be better, although the problem is that if contrib plugin managers don't support attributes, then implementations also can't support attributes, which means it's harder to guarantee everything support 13.0.0 in time, but we'd only be giving people longer to make the change, not enforcing that they can't make it... For that issue anyway.

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 0792d0f1 on main
    refactor: #3571068 Remove deprecated code from lib/Extension, lib/Form,...
berdir’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.