Problem/Motivation

When saving the Language Content Settings form (`/admin/config/regional/content-language`) without making any changes, Drupal creates hundreds of unnecessary `core.base_field_override.*` configuration entities for entity types and bundles that are **not translatable**

Steps to reproduce

Enable the Content Translation module
Visit `/admin/config/regional/content-language`, Click "Save configuration" without making any changes
Create a new taxonomy which is not translatable
Visit `/admin/config/regional/content-language`, Click "Save configuration" without making any changes
Run `drush config:export --diff`

Issue fork drupal-3570351

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alorenc created an issue. See original summary.

alorenc opened merge request !14560

alorenc opened merge request !14561

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented
Assigned: alorenc » Unassigned
Status: Active » Needs review
andras_szilagyi’s picture

andras_szilagyi commented
Status: Needs review » Needs work

The solution looks correct to me, also works as expected, glad to see it addressed. Just needs attention with failed pipeline on the main

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented

I've re-merged the main branch because it seems the previous version had some test bugs.

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented
Status: Needs work » Needs review
andras_szilagyi’s picture

andras_szilagyi commented
Status: Needs review » Reviewed & tested by the community

Looks good

  • catch committed bd66df67 on 11.x 
    fix: #3570351 content_translation_form_language_content_settings_submit...

  • catch committed 3fcad25a on main 
    fix: #3570351 content_translation_form_language_content_settings_submit...

catch closed merge request !14560

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

This looks right to me.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.