Problem/Motivation

This is a public follow-up to add tests for SA-CORE-2025-008.

These tests were provided by @larowlan, @xjm, and @mohit_aghera in the security team issue https://git.drupalcode.org/security/21-drupal-security/-/issues/1

Release notes snippet

Adds cache header tests for custom file schemes.

Issue fork drupal-3570172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

akalata created an issue. See original summary.

akalata opened merge request !14534

akalata’s picture

akalata commented
Status: Active » Needs review
akalata’s picture

akalata commented
Assigned: akalata » Unassigned
xjm’s picture

xjm
she/her
Primary language English
commented

Added some additional credits from the private issues (one on s.do, one on GL) that hadn't made it onto the public one.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

I reverted the change from https://git.drupalcode.org/project/drupal/-/commit/d2a47e6fd74dde54f4265...
Applied the MR and ran the tests in core/modules/file/tests/src/Functional/DummyStreamWrapperFileTest.php

dummy_public_scheme = PASS
private_scheme = PASS
dummy_private_scheme = FAIL The text "private" was not found anywhere in the "Cache-Control" response header.
temporary_scheme = FAIL The text "private" was not found anywhere in the "Cache-Control" response header.

Assuming the first two passing are fine and was intended to to expand coverage even for currently working scenarios.

LGTM

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 843199c7f3b to main and 0231c1f3d03 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 0231c1f3 on 11.x 
    task: #3570172 Add cache header tests for custom file schemes

By:...

  • alexpott committed 843199c7 on main 
    task: #3570172 Add cache header tests for custom file schemes

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.