Problem/Motivation

The form for staff to add a new declaration of a certain type is messy. The fields are oddly ordered and without priority, making it easy for staff to get confused.

Steps to reproduce

(1) Create a new declaration type.
(2) As someone with the permission to make a declararion for others, go to the user context form, enter the donor address, press next, and select the new declararion type
(3) See the resulting form

See screenshot attached.

Proposed resolution

I think the solution needs to involve a number of pieces:

1. Better default weights for fields in a registration type's form display. The OOTB box ordering should be sane for a new registration type. I suggest these default weights:
- the 'Information' pane
- declared date
- any configured fields added to the registration type
- validity
- start date
- end date
- written confirmation sent date
- changed date
- evidence
- revision information
(some of these also effect other record types, probably for the good)

2. The following should be hidden by default in all form modes:
- written confirmation sent date
- changed date
- validity (once #3557144: Allow declaration types to specify field defaults is implemented)

3. Simplify the revision information:
- remove the 'Revision information' label, 'Notes' is plenty
- Alter 'Briefly describe the changes you have made" to something like "You may enter additional notes about the declaration" when the declaration is new.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
Email declaration type.png424.31 KBjonathanshaw

Issue fork gift_aid-3567991

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jonathanshaw created an issue. See original summary.

jonathanshaw’s picture

Issue summary: View changes

adamps made their first commit to this issue’s fork.

adamps’s picture

Two other issues are tiny fixes and not worth the overhead of creating separate MR so I'll include them here

Also this MR includes some left-over coding standards fixes from an earlier issue.

adamps’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • adamps committed 224a1784 on 1.x
    Bug: #3567991 Declaration add form for staff is messy
    
    By: jonathanshaw...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.