Exempt 'system.modules_uninstall' route in UpdateHooks::pageTop()

Totally agreed. Needs subsystem maintainer review.

I hated it when folks added that fragile parsing code without catching possible exceptions. But here we are.

Probably best for scope to just do 1 thing at a time, so let's start with early return in pageTag() for system.modules_uninstall (and system.theme_uninstall).

We should look for and if needed, open another issue about catching those exceptions at the right places instead of letting them WSOD a site. 😬

Thanks!
-Derek

p.s. I tried targeting the new main branch for the MR, but that's still not quite working, so I'm sticking with 11.x for now.

Re:

Evaluate if the modules overview page should be exempted

I vote no. That's one of the primary pages for why we added the hook_page_top stuff in the first place. In fact, there's code for a more detailed / verbose report on system.modules_list (and system.themes_page):

        // If we are on the appearance or modules list, display a detailed
        // report of the update status.
        case 'system.themes_page':
        case 'system.modules_list':
          $verbose = TRUE;
          break;

Crossing that off from remaining tasks.

IMO that's wrong solution as all existing sites getting this fatal error, IMO release name should be changed instead to dev-main at least in composer as even live sites started to fail and it will cause owners to disable update module - security--

@cmlara for example from https://git.drupalcode.org/project/drupal/-/blob/11.3.x/core/modules/hel... and other help topics

To be clear, this cannot help with the current situation. The immediate site crashing was quickly resolved at

#3567494: Filter main branch from the list of core releases

The fatal errors from blindly trusting the feed to always have valid versions will be resolved at

#3567483: Update manager crashing admin panel with uncaught exceptions parsing version strings

This issue has nothing to do with encouraging folks to disable update status. It’s to give non-CLI site admins a way to uninstall in case another similar bug brings down sites and they need to (temporarily) turn off update status to bring the site online at all.

Meanwhile, from a UX perspective, if you’re already in the act of trying to uninstall something from your site (perhaps because update status told you there’s a security problem or it was marked unsupported, etc), you probably don’t need to/ want to see more error messages about unsupported releases to distract you from the task you were already in the middle of. The same reason we skip other admin paths for this hook applies to this particular admin page. So this was an oversight from 20 years ago that we should have had all along, even if it’s not also a very useful failsafe in case of trouble.

Re #7 I don’t see how that’s gonna help. If /admin itself is crashing, how are you gonna find /admin/extend or whatever? Hopefully you’ve got toolbar or navigation enabled. Hopefully those work enough to let you find it. Or you ask The Internet and Google/AI will tell you. But I don’t think we want less info about update status on one of the main pages where you need to be reminded about update status if you’re not already looking at the available updates report itself.

Recommended way to test this one?

Re: #14: Added steps to reproduce to the summary. Hopefully that's clear and works for you.

Sorry just realized that the MR needs to be updated for main. Sorry for taking so long if this comes around again just ping me and I'll move to the top of my list @dww.

Changed MR target, rebased. Pipeline is running. Hope it's green. If not, someone else will have to restart it. 😅

Thanks!
-Derek

following the steps you provided.
I downloaded the zip https://www.drupal.org/project/login_disable/releases/2.1.2 since composer doesn't work
I did edit the .info file to include 12 so I could install

Applying the MR I don't get the message

seems to work as advertised

Committed d867a4a and pushed to main, committed e644f95 and pushed to 11.x, and committed b1608d1 and pushed to 11.3.x. Thanks!

Sweet, thanks!