Problem/Motivation

Pipeline has several errors, lets fix the ones we can.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork quiz-3565490

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !61

smustgrave’s picture

smustgrave commented
Status: Active » Needs work

This still needs work, and seems rules no longer works in 11.3 (yay!)

dadderley’s picture

dadderley commented

Quick question, is the fix in this issue https://www.drupal.org/project/quiz/issues/3564150 in the dev release?
Because for me right now quiz is broken. Please see my comment there. https://www.drupal.org/project/quiz/issues/3564150#comment-16414405

Thanks

smustgrave’s picture

smustgrave commented

quiz doesn't work in 11.3 right now, and neither does rules https://www.drupal.org/project/rules/issues/3563101

dadderley’s picture

dadderley commented

Thankyou.
I downgraded to Drupal to 11.2.10 and it works again.

smustgrave’s picture

smustgrave commented
Version: 7.0.x-dev » 7.1.x-dev

smustgrave opened merge request !66

smustgrave’s picture

smustgrave commented

This is what I may have to do

1. Wait on rules to be fixed for 11.3/10.6
2. Make a new branch 7.1.x that is just 11.3/10.6
3. While I'm at it start a 7.2.x branch for just 11.3

smustgrave’s picture

smustgrave commented
Version: 7.1.x-dev » 8.0.x-dev
smustgrave’s picture

smustgrave commented
Title: Fix pipeline » Fix pipeline + start 8.0.x branch for 11.3/12

smustgrave opened merge request !67

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dadderley’s picture

dadderley commented

OK,
I am sorry, but I find this all quite confusing.
Does this actually work now in 11.3?

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented

@dadderley I believe there are still errors when trying to run certain versions of quiz on 11.3. For example I am running 11.3 now fine, but just updated quiz from 7.0.4 > 7.1.0 and started getting the construct error you called out in https://www.drupal.org/project/quiz/issues/3564150#comment-16414405.

I believe @smustgrave indicated a 7.2.x branch was coming for use with 11.3 but I don't see that yet. I do see that the 8.x-dev branch looks to resolve this specific error: https://git.drupalcode.org/project/quiz/-/blob/8.0.x/src/Controller/Quiz...

where "$request_stack" is added back as the last argument.

For now I am locking to 7.0.4 until we have stability.

smustgrave’s picture

smustgrave commented

So 7.1.x isn't working right now? Did you also update rules?

smustgrave’s picture

smustgrave commented
Version: 8.0.x-dev » 7.1.x-dev
Status: Closed (fixed) » Needs work
ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented

Yes, or rather was already on Rules 4.0.1.
As near as I can tell it's just because of the missing $request_stack argument in the QuizController and QuizQuestionController, which is fixed in 8.x

smustgrave opened merge request !75

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

This has been getting me all kinds of turned around

Okay 7.0.x = 10.3 + 11
When you get to 11.3 switch to 7.1.x or 8.0.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.