Problem/Motivation

I the previous issue we worked on the plugin implementation.
The scope of this issue is to apply the generated fix from AI into the CKEditor.

- Find element by marker or attributes
- Map DOM to CKEditor model
- Replace with corrected HTML
- Clean up CKEditor markup
- Re-run Editoria11y check
- Tests

Acceptance criteria:
- Accepting suggestion updates content in CKEditor
- Fix persists after editor operations
- Editoria11y re-checks and shows issue resolved

Issue fork ai_editoria11y-3563900

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joevagyok created an issue. See original summary.

joevagyok’s picture

joevagyok commented
Issue summary: View changes

joevagyok opened merge request !3

nikro’s picture

nikro commented
Assigned: joevagyok » Unassigned

Hey there, took me a while to go through the diff as it's not small, found a few edge cases, some of these can be just committed as-is (but to create another smaller well-defined issue in the issue queue for later follow-up).

Overall it works well, replaces stuff nicely. Probably usability-wise the only discomforting thing is losing the action-history (unable to do undo anymore).

I'll leave it to you to decide, if you just create follow-up issues then consider it RTBC-ed :)

joevagyok’s picture

joevagyok commented
Status: Active » Needs review

It wasn't na easy feat! But I think after a redesign of the solution I addressed the history issue!

itmaybejj’s picture

itmaybejj commented

I've been tuning some things to get rid of race conditions, and ended obscuring some method calls, so I recommend calling
Drupal.Ed11y.refresh()
instead of
window.Ed11y.checkAll();

I'll have the next alpha or beta out within the week. We're starting to test formally in our environment now.

nikro’s picture

nikro commented
Status: Needs review » Needs work

Hey @joevagyok - looks good, the undo/redo works well, you did end-up using editor.mode.change() - awesome.

There's one more issue that I'm not sure you seen, regarding matching regex tags. I think it can accidentally create some broken HTML ;(

Also #6's comment might be useful to bake-in :)

joevagyok’s picture

joevagyok commented

Applied the proposed fix from #6.

nikro’s picture

nikro commented
Status: Needs work » Reviewed & tested by the community

  • joevagyok committed 0464dde4 on 1.x 
    Issue #3563900: Apply the fixed element to the editor.
joevagyok’s picture

joevagyok commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.