Problem/Motivation

An entity's ::toUrl() method can throw an exception for various reasons. Siteimprove does not catch these exceptions.

Proposed resolution

Catch the exception.

Issue fork siteimprove-3562565

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tinny created an issue. See original summary.

tinny opened merge request !42

tinny’s picture

tinny commented
Status: Active » Needs review
beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Status: Needs review » Fixed

Thanks @tinny. I have included your changes in a bigger rewrite of the getEntityUrls method to solve some other problems too. It was commited as part of #3591528: Wrong URL send to Siteimprove when frontpage is an entity.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.