Group revisions are not cleaned

@jura.khrapunov - Thanks for reporting this. I've been trying to replicate this locally with tests but no luck.

I've went ahead and added a few new group specific tests for your exact scenario.

• testAgeAndAmountPluginsGroup - Both plugins enabled, old revisions deleted correctly
• testAgeAndAmountAllRecentGroup - All recent revisions protected (intersection logic)
• testAmountWouldDeleteAgeProtectsGroup - Age protects recent revisions from Amount deletion

All tests seem to pass, including the combined Age + Amount scenario you described.

When both plugins are enabled, revisions are only deleted if they appear in BOTH deletion sets (intersection):

• If all your revisions are recent (< 6 months), Age returns empty → nothing deleted
• If you have fewer revisions than your Amount threshold, Amount returns empty → nothing deleted
• Only revisions that are BOTH old enough AND exceed the count get deleted

A few questions to help debug:

1. Group module version? (2.x vs 3.x)
2. Drupal core version?
3. How old are the Group revisions?
4. How many revisions exist vs your Amount threshold?
5. Are the revisions published (status=1)?

Thanks for the extra details - I think I was able to replicate this. The issue appears to be in EntityHelper::getEntityIds() - it was using accessCheck(TRUE) which triggers Group's access hooks when enumerating entities. During drush/cron runs, Group tries to check memberships and silently fails, so no entities get found for cleanup.

The fix should be straightforward - change to accessCheck(FALSE) since this is an admin operation and it follows the same pattern as core for batch processing.

Opening a MR with a patch and test, let me know if it works for you.

Thanks for confirming the patch works and helping out with this.

Yeah, the status=0 accumulation is a valid concern. We protect unpublished revisions by design (could be draft work), but 3-year-old drafts are probably safe to clean up.

I dug into how node_revision_delete handles this - they use a 3 state system keep/delete/no-opinion on each revision. I'm thinking of adopting that for 2.x, which would let us add a WorkflowState plugin:

• Pick which moderation states can be deleted (draft, archived, etc.)
• Separate age threshold for those states
• Falls back to status=0 when Content Moderation isn't enabled

That way you get separate policies for published vs draft cleanup. What do you think about that? We can spin this off into a separate issue.

Yeah you're right - we can just protect forward drafts and treat old drafts as regular deletion candidates. Way simpler than what I was originally thinking...

Basically change the Amount / Age plugin from filtering by status=1:

$buckets = $this->getRevisionIds($entity, [
  ['field' => $this->getStatusField($entity), 'value' => 1],
]);

To filtering by revision ID:

$revisionKey = $entity->getEntityType()->getKey('revision');
$current = (int) $entity->getRevisionId();

$buckets = $this->getRevisionIds($entity, [
  ['field' => $revisionKey, 'value' => $current, 'operator' =>
'<'],
]);

This also handles #3556356 (forward revisions) since they're automatically excluded from the query.

What do you think? I can throw together a patch with some tests to confirm it works as expected, it might be better on the other issue though.

Thanks again for taking the time to test this out, added the new patch.

Awesome, glad it's working now. Thanks for testing - good catch on the translation issue too, I'll take a look.