Problem/Motivation

In the Advanced links tab in the CKEditor 5 plugin setting section (under Text Formats Editors), the less than and greater than characters are encoded twice, so it's appears as < and >.

Steps to reproduce

Update to 2.3.3
Clear your cache
Go to one of the Text Formats and Editors and select one of the formats that allows links (ie. rich_text; /admin/config/content/formats/manage/rich_text)
Go to the CKEditor 5 plugin settings and swtich to the Advanced links tab.

screenshot of Advanced links tab

Proposed resolution

Remove the recently added HTML::escape for the placeholder text https://git.drupalcode.org/project/editor_advanced_link/-/commit/d156b5d....

*note* placeholder text will be escaped (see https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...)

Remaining tasks

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jasongose created an issue. See original summary.

jasongose’s picture

Issue summary: View changes

jasongose’s picture

Title: less than and greater than double encoded on Advanced links tab under CKEditor Plugin settintgs » less than and greater than double encoded on Advanced links tab under CKEditor Plugin settings
jasongose’s picture

Status: Active » Needs review
jannakha’s picture

it was reported here - https://www.drupal.org/project/editor_advanced_link/issues/3551244 (I can't reproduce the reported issue anymore) weird

jasongose’s picture

Version: 2.3.x-dev » 2.3.3

(I just realized I had set this to 2.3.x-dev and not 2.3.3; fixed)

jasongose’s picture

Version: 2.3.3 » 2.3.x-dev

it was reported here - https://www.drupal.org/project/editor_advanced_link/issues/3551244 (I can't reproduce the reported issue anymore) weird

Oh goodness, I misread that (and thought the 2.3.x-dev branch had been updated).

I wasn't able to reproduce the issue reported in issue 3551244 and it looks like the 2.3.x-dev branch hasn't changed since my report, so I guess the 2.3.x-dev Version is still accurate.

I just updated my 10.5 drupal site to 10.5.7 and in my drupal 11.2.9 sandbox and validated that I'm still seeing the issue.

My apologies for the 'noise'.

jannakha’s picture

Status: Needs review » Reviewed & tested by the community

no more double encoding.
good for release.

vladimiraus’s picture

Status: Reviewed & tested by the community » Fixed

Thanks you for your contributions.
Merged. 🍻

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.