Problem/Motivation

WorkspaceNegotiatorInterface::getActiveWorkspace() has been deprecated in Drupal 10.3 and removed in D11 (see https://www.drupal.org/node/3443765), but the implementations of that method were not removed.

Proposed resolution

Remove SessionWorkspaceNegotiator::getActiveWorkspace() and TestWorkspaceNegotiator::getActiveWorkspace(), it's dead code :)

Remaining tasks

Review.

User interface changes

Nope.

Introduced terminology

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

Nope.

Issue fork drupal-3557917

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !13838

amateescu’s picture

amateescu commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Appears to have caused several test failures.

amateescu’s picture

amateescu commented
Status: Needs work » Needs review

Fixed :)

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward enough.

  • longwave committed be07eed9 on 11.3.x 
    fix: #3557917 Remove stale implementations of...

  • longwave committed 465ffd36 on 11.x 
    fix: #3557917 Remove stale implementations of...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

As this is dead code and it touches the service definition, decided not to backport this any further as it's not hurting anything as-is.

Committed and pushed to 11.x and 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !13838

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.