Problem/Motivation

There is a todo here : https://git.drupalcode.org/project/drupal/-/blob/4da595fb162a3a445dabbdb...

But #956186: Allow AJAX to use GET requests has been committed.

Steps to reproduce

Proposed resolution

Remove the todo (or update it if some work is still needed).

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3556936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I think we can just delete the todo. We have AjaxResponse, which does not implement CacheableResponseInterface, and CacheableAjaxResponse, which does - the code path already handles both cases. The surrounding code is quite complicated and I don't see an immediate way to simplify it without doing the check for CacheableResponseInterface twice.

quietone’s picture

quietone commented
Parent issue: » #3123832: [META] Fix @todo items referencing closed issues

prudloff opened merge request !13894

prudloff’s picture

prudloff commented
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Nothing more to say than what I already said in #2.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed a477cf65 on 11.3.x 
    task: #3556936 Outdated todo in...

  • catch committed bc03d249 on 11.x 
    task: #3556936 Outdated todo in...

catch closed merge request !13894

catch’s picture

catch
he/him
Primary language English
commented

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.