Theming of content boxes - code is repeated inside each layout plugin and not abstract enough

It seems to work OK for me, but I'm only using the 'columns' layout. I hope that there weren't any small differences between the way boxes are rendered in the different layout plugins.

Ok, so my patch is definitely a good idea - they can still do that by overriding the box theming function in their template file or elsewhere.

As a general rule, I strongly encourage using multiple layers of abstraction in order to allow users to override stuff without having to duplicate whole pages worth of functionality.

In this case, I would use a mediator theming function, which would look something like this: (I'm at home now, so I don't have the code in front of me)

function theme_mysite_box($args...) {
   $func = theme_get_function('mysite_box_' . $layout);
   if ($func) {
      $func($args...)
   }
   else {
     // default behavior, or a call to a default function
   }
}

What do you say?

Hmmm... so, are you waiting for me to make those changes, or are you going to implement them yourself sometime in the future?

What I mean is - are you waiting for a patch submission by myself?