Problem/Motivation

cspell reports, among other things,

config/install/saml_sp.settings.yml:22:12 - Unknown word (Urlencoding) -- lowercaseUrlencoding: false
Suggestions: [Urlencode, Urlencoded]
config/schema/saml_sp.schema.yml:80:18 - Unknown word (Urlencoding) -- lowercaseUrlencoding:
Suggestions: [Urlencode, Urlencoded]
config/schema/saml_sp.schema.yml:98:56 - Unknown word (intentifies) -- identifier that the IdP intentifies this site for the Relying
Suggestions: [intensifies, intensifier, intensities, intensifiers, interties]
config/schema/saml_sp.schema.yml:121:85 - Unknown word (identiy) -- Provider will use to identiy itself by, this may
Suggestions: [identic, identify, identity, IDENTITY, ident]
config/schema/saml_sp.schema.yml:125:53 - Unknown word (Identiy) -- name is provided to the Identiy Provider, to identify
Suggestions: [Identic, Identify, Identity, IDENTITY, Ident]
modules/saml_sp_drupal_login/config/schema/saml_sp_drupal_login.schema.yml:22:68 - Forbidden word (e-mail) -- on the site but the e-mail address differs from
Suggestions: [email, emil, emails, entail, Emil]
Suggestions: [Allowlist*, Whitest, Whitefish, Whiteouts, Whitebaits]
modules/saml_sp_drupal_login/src/Controller/SamlSPDrupalLoginController.php:114:250 - Unknown word (folloing) -- CSRF Whitelist. the folloing url %csrf_url was added
Suggestions: [folioing, following, FOLLOWING, fooling, folding]
modules/saml_sp_drupal_login/src/EventSubscriber/SamlSpDrupalLoginSubscriber.php:104:363 - Unknown word (successflly) -- will prevent users from successflly using this IdP to login
Suggestions: [successfully, successful, SUCCESSFUL, successively]
modules/saml_sp_drupal_login/src/EventSubscriber/SamlSpDrupalLoginSubscriber.php:115:363 - Unknown word (successflly) -- may prevent users from successflly using this IdP to logout
Suggestions: [successfully, successful, SUCCESSFUL, successively]
modules/saml_sp_drupal_login/src/Form/SamlSpDrupalLoginConfig.php:93:87 - Forbidden word (e-mail) -- on %site_name but the e-mail address differs from
Suggestions: [email, emil, emails, entail, Emil]
saml_sp.module:9:63 - Unknown word (recognised) -- authentication to be recognised in
Suggestions: [recognized, recognize, recognizer, recoined, recognizes]
saml_sp.module:177:15 - Unknown word (Urlencoding) -- 'lowercaseUrlencoding' => (bool) $config
Suggestions: [Urlencode, Urlencoded]
saml_sp.module:177:71 - Unknown word (Urlencoding) -- get('security.lowercaseUrlencoding'),
Suggestions: [Urlencode, Urlencoded]
saml_sp.module:470:38 - Unknown word (remoev) -- sure that we want to remoev all password fields
Suggestions: [remove, rewove, removed, remover, removes]
src/Entity/Idp.php:76:65 - Unknown word (identiy) -- Provider server will use to identiy itself.
Suggestions: [identic, identify, identity, IDENTITY, ident]
src/Form/IdpDeleteForm.php:60:22 - Unknown word (Nevermind) -- return $this->t('Nevermind');
Suggestions: [Nevermore]
src/Form/IdpForm.php:90:99 - Unknown word (identiy) -- Provider will use to identiy itself by, this may
Suggestions: [identic, identify, identity, IDENTITY, ident]
src/Form/IdpForm.php:98:67 - Unknown word (Identiy) -- name is provided to the Identiy Provider, to identify
Suggestions: [Identic, Identify, Identity, IDENTITY, Ident]
src/Form/SamlSpConfig.php:452:33 - Unknown word (Urlencoding) -- security']['lowercaseUrlencoding'] = [
Suggestions: [Urlencode, Urlencoded]
src/Form/SamlSpConfig.php:458:69 - Unknown word (Urlencoding) -- iddenValue('security.lowercaseUrlencoding'),
Suggestions: [Urlencode, Urlencoded]
src/Form/SamlSpConfig.php:459:61 - Unknown word (Urlencoding) -- Overridden('security.lowercaseUrlencoding'),
Suggestions: [Urlencode, Urlencoded]
src/SAML/SamlSPMetadata.php:57:24 - Unknown word (Displaynames) -- $organizationInfoDisplaynames = [];
Suggestions: [Displayname, displayName]
src/SAML/SamlSPMetadata.php:63:26 - Unknown word (Displaynames) -- $organizationInfoDisplaynames[] = << Suggestions: [Displayname, displayName]
src/SAML/SamlSPMetadata.php:70:96 - Unknown word (Displaynames) -- n", $organizationInfoDisplaynames) . "\n" . implode("
Suggestions: [Displayname, displayName]
src/SAML/SamlSPResponse.php:19:6 - Unknown word (ocurrence) -- $ocurrence = array_count_values
Suggestions: [occurrence, occurrences, currency, coherence, opulence]
src/SAML/SamlSPResponse.php:22:58 - Unknown word (ocurrence) -- signedElements) && $ocurrence['samlp:Response'] >
Suggestions: [occurrence, occurrences, currency, coherence, opulence]
src/SAML/SamlSPResponse.php:23:58 - Unknown word (ocurrence) -- signedElements) && $ocurrence['saml:Assertion'] >
Suggestions: [occurrence, occurrences, currency, coherence, opulence]
src/SAML/SamlSPResponse.php:24:53 - Unknown word (ocurrence) -- signedElements) && $ocurrence['Assertion'] > 1) |
Suggestions: [occurrence, occurrences, currency, coherence, opulence]

Steps to reproduce

see https://git.drupalcode.org/project/saml_sp/-/jobs/6337729

Proposed resolution

standardize spelling of English words

Remaining tasks

make an MR

Issue fork saml_sp-3546849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

benstallings created an issue. See original summary.

benstallings opened merge request !65

benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Active » Needs review

jproctor made their first commit to this issue’s fork.

jproctor’s picture

jproctor
they/them
Primary language English
commented
Status: Needs review » Fixed

Merged. Thank you for all these!

I reverted your changes to lowercaseUrlencoding because changing the name of a config element requires an update hook, which can wait until we have another structural change to the schema. I wanted to be able to incorporate the rest of your changes without waiting for that.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.