Problem/Motivation

Try to convert some presenter templates code to use more components directly.

Accordion component could be used in:
- templates/system/details--accordion.html.twig

Alert component could be used in:
- templates/input/datetime-wrapper.html.twig

Button component could be used in:
- templates/ui_patterns_library/ui-patterns-component-metadata.html.twig
- templates/ui_patterns_library/ui-patterns-overview-page.html.twig
- templates/ui_styles_library/ui-styles-overview-page.html.twig

Card component could be used in:
- templates/comment/comment.html.twig
- templates/media/media--media-library.html.twig

Table component could be used in:
- templates/commerce/checkout/commerce-checkout-order-summary.html.twig
- templates/commerce/promotion/commerce-coupon-redemption-form.html.twig
- templates/ui_patterns_library/ui-patterns-component-table.html.twig

Issue fork ui_suite_bootstrap-3544817

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grimreaper created an issue. See original summary.

kilik047’s picture

kilik047 commented
Assigned: Unassigned » kilik047

kilik047 opened merge request !310

kilik047’s picture

kilik047 commented

Template fixed:

- templates/input/datetime-wrapper.html.twig
- templates/ui_patterns_library/ui-patterns-component-metadata.html.twig
- templates/ui_patterns_library/ui-patterns-overview-page.html.twig
- templates/ui_styles_library/ui-styles-overview-page.html.twig

Todo:

- templates/system/details--accordion.html.twig
- templates/comment/comment.html.twig
- templates/media/media--media-library.html.twig
- templates/commerce/checkout/commerce-checkout-order-summary.html.twig
- templates/commerce/promotion/commerce-coupon-redemption-form.html.twig
- templates/ui_patterns_library/ui-patterns-component-table.html.twig

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work
kilik047’s picture

kilik047 commented
Assigned: kilik047 » Unassigned
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs work » Needs review

Unchanging:
- templates/system/details--accordion.html.twig: Not possible to administer the heading attributes in accordion_item
- templates/ui_patterns_library/ui-patterns-component-table.html.twig: component library will be reworked in UIP 2.1/2.2

  • grimreaper committed 56221cf6 on 5.2.x authored by kilik047 
    chore: #3544817 Use more components in presenter templates. Simplify...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.