Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The text of some popup boxes like
Loading
Are you sure you want to cancel your ...
Are you sure you want to approve the ...
Are you sure you want to disapprove the ...
can not be translated.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | user_relationship_blocks.353463.patch | 6.65 KB | jaydub |
| #4 | user_relationship_node_access.353463.patch | 1.54 KB | jaydub |
| #3 | user_relationship_defaults.353463.patch | 3.17 KB | jaydub |
| #3 | user_relationship_implications.353463.patch | 1.14 KB | jaydub |
| #2 | user_relationships_api.api_.inc_.353463.patch | 1.49 KB | jaydub |
Comments
Comment #1
jaydub commentedOk I've taken a look at this and in trying to dump translations I am seeing a lot of warnings from the Drupal translation layer. Going to have to take a closer look here...A quick glance shows that things like remove t() calls from hook_menu() implementation will be on the list as the change to d6 means that t() calls should be removed from menu items.
Comment #2
jaydub commentedOk posting some patches here to improve translation. Most of the changes are from errors returned by the potx module which help to point out places where translation best practices are not being followed.
These probably should be reviewed before committing as a sanity check.
Posting one patch per module/sub-module
Comment #3
jaydub commentedUR-Implications and UR-Defaults
Comment #4
jaydub commentedUR-Node Access and UR-Blocks
Comment #5
alex.k commented@jaydub great stuff, thank you. Apologies for not looking at this earlier. Everything looks good - please apply when you have a chance. Menu items already had t() removed, actually, in a another issue, so that will probably give you conflicts with these patches.
Comment #6
jaydub commentedI'll go over these again since some have been addressed and others might have different copy now.
Comment #7
andrenoronha commentedComment #8
alex.k commentedReviewed and committed these patches. Thx again.