Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2025 at 22:17 UTC
Updated:
1 Sep 2025 at 13:35 UTC
Jump to comment: Most recent
Comments
Comment #2
vishal.kadamComment #3
berramou commentedI did a quick review, I didn't find any serious security issue but still need to sanitize alias and original parts before replacing, and maybe add
$node->access()to check node access.Something like:
Comment #4
berramou commentedComment #5
vishal.kadamComment #6
iheb.attia commentedberramou #3
At this stage of the process, the alias and original strings are already sanitized. The plugin filter is executed after the node is built and its access is checked, so we can be confident that the node access logic has already been enforced upstream.
Also, note that the final output is passed through Xss::filter() after rendering, which strips any remaining HTML tags. So even if the alias or original contained HTML at some point, it will be removed before display, ensuring XSS protection.
Let me know if you still have concerns, but from what I see, the current flow already handles both access control and sanitization appropriately
Comment #7
berramou commentedThank you @iheb.attia for your contribution and explications.
It's clear, since there is no other security issue, i will move this to fixed!
Comment #8
berramou commentedComment #9
avpadernoThese issues are fixed only when the applicant gets the role that allows to opt projects into security advisory coverage. That can only be done by project moderators.
Comment #10
iheb.attia commentedComment #11
rushikesh raval commentedI am changing the issue priority as per issue priorities.
Comment #12
avpadernoActually, this project does not have enough Drupal code, differently from the other one. We should continue with the other application.
Comment #13
avpaderno