Problem/Motivation

There are example components from before the namespace change (with SDC), these need to be removed so that civictheme sub-theme's built with this tool work correctly.

Also while these example components demonstrate how to carry out overrides, this is better placed to be in documentation rather than a theme that gets activated by the site.

Comments

richardgaunt created an issue. See original summary.

richardgaunt’s picture

richardgaunt commented

These are the examples:

https://github.com/civictheme/monorepo-drupal/tree/develop/web/themes/co...
https://github.com/civictheme/monorepo-drupal/tree/develop/web/themes/co...
https://github.com/civictheme/monorepo-drupal/tree/develop/web/themes/co...

We have had reports that these have ended up in production sites which was not their intent.
Aside from the problems with the old twig namespaces being used and breaking newly created sub-themes.

gargsuchi’s picture

gargsuchi commented

As a workaround, please delete the following directories from your new sub-theme manually (unless you have added some code changes):

  1. components/01-atoms/demo-button
  2. components/02-molecules/navigation-card
  3. components/03-organisms/header

We will address this issue in code soon.

alan.cole’s picture

alan.cole commented

PR: https://github.com/civictheme/monorepo-drupal/pull/1392

Removed the example override components from the starterkit. These components were added to help a developer understand the ways in which a custom component can be created, however we have seen that sometimes these components are not removed when creating an actual theme, and since the 1.11 upgrade, have not been properly maintained.

The more appropriate place for examples would be either in documentation, or a separate folder / repo specifically designed for showing examples, rather than the actual starter kit.

alan.cole’s picture

alan.cole commented
Status: Active » Needs review
richardgaunt’s picture

richardgaunt commented
Status: Needs review » Reviewed & tested by the community
richardgaunt’s picture

richardgaunt commented

Before release we need new documentation explaining overrides of SDC components. The examples were misleading with the change in components.

Think we should also add link to this docs at the top of the slack channel.

  • 0c8e32c5 committed on 1.x 
    Issue #3527182: Remove examples from civictheme_starter_kit (#1392)
fionamorrison23’s picture

fionamorrison23 commented
Issue tags: +civictheme-release-1.12
fionamorrison23’s picture

fionamorrison23 commented
Version: 1.x-dev » 1.12.0
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.