Problem/Motivation

Elasticsearch Connector mentions that we integrate with the Facets module on the front page. We also now have a manual test in our documentation for Developing the Facets module integration.

We should make sure this integration does not regress!

Proposed resolution

See if there are any existing automated tests for the Facets module.

Add "drupal/facets": "^3" to Elasticsearch Connector's "require-dev".

Transform the manual test in our documentation into an automated test.

Once merged, update the documentation (likely, many of the Setup steps will no longer be necessary).

Remaining tasks

  1. Write a merge request - merge request !159 created by @marckwee (and @mparker17)
  2. Review and feedback - skipped by @mparker17 in #7
  3. RTBC and feedback - reviewed by @mparker17 in #7
  4. Commit - done by @mparker17 in #8
  5. Update documentation - done by @mparker17 in revision 14222086
  6. 9.0.x release - released by @mparker17 in 9.0.0-alpha1 by #13
  7. 8.0.x release - released by @mparker17 in 8.0.0-alpha6

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork elasticsearch_connector-3498644

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mparker17 created an issue. See original summary.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

(update the issue summary for consistency with similar tickets for other module integrations)

marckwee made their first commit to this issue’s fork.

marckwee opened merge request !159

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

@marckwee and I have been pair-programming on this issue so that we can unblock #3527020: Add an event to modify filter parameters before processing and #3526730: Boolean facet does not show the "FALSE" value. Due to time constraints, I'm going to continue working on this issue for a bit!

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

I noticed the manual test case no longer worked for the Category field; but it worked for the Keyword field, so I've updated the manual test case.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community
Issue tags: -Needs tests

This no longer "needs tests", they're in the branch :)

As a maintainer, I'm reviewing and RTBCing in one step.

All the lints and tests pass; and I can see the test added in this issue passing as well. Reviewing the code, it looks clear to me, so I'm happy to merge this (and reduce the number of manual tests that I have to run)!

  • mparker17 committed b43a683c on 8.0.x authored by marckwee 
    feat: #3498644 Automated Functional test for facets module integration...
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
Issue tags: +Needs documentation updates

Merged, thanks @marckwee!

I can update the documentaton.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Issue tags: -Needs documentation updates

I've updated the documentation!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

This change was released in elasticsearch_connector-9.0.0-alpha1 (but doesn't have a release in the 8.0.x release series yet... that's coming soon).

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

This was released in elasticsearch_connector-8.0.0-alpha6