Problem/Motivation

2.0.2 is listed as compatible with ^9.4 but it is not compatible with 9.5.11 (and guessing therefore not with ^10 either).

I get this:

Fatal error: Uncaught Error: Class "Drupal\Core\Render\Element\FormElementBase" not found in E:\www\Noah\dev\web\modules\contrib\term_reference_tree\src\Element\CheckboxTree.php:14

and that class does indeed not exist in Core for 9.5.11.

2.0.1 does work with 9.5.11.

CommentFileSizeAuthor
#11 Screenshot-2-after-patch.png338.97 KBnikhil_110
#11 Screenshot-1-before-patch.png631.69 KBnikhil_110
#4 term_reference_tree-3498620.patch3.07 KBp4trizio
#3 compatibility-issue-3498620.patch1.12 KBdeepali sardana

Issue fork term_reference_tree-3498620

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liquidcms created an issue. See original summary.

deepali sardana’s picture

deepali sardana commented
Assigned: Unassigned »
deepali sardana’s picture

deepali sardana commented
Assigned: » Unassigned
StatusFileSize
new compatibility-issue-3498620.patch1.12 KB

I was trying to create mr but not able to create that please accept the patch and review it i have change the core requirement and done changes in checktree.php

p4trizio’s picture

p4trizio commented
Title: 2.0.2 not compatible with 9.5.11 » 2.0.2 not compatible with Drupal core < 10.3.0
StatusFileSize
new term_reference_tree-3498620.patch3.07 KB

I have a 10.2.12 and it is not working either.
I guess we need a major version of the module.
Attaching a patch (only for backward compatibility for unsupported Drupal core versions)

dieterholvoet’s picture

dieterholvoet commented

There's no need to start using the new base classes yet, the old ones will only be removed in Drupal 12 (change record). It's okay to revert back to using the old ones.

dieterholvoet changed the visibility of the branch 3498620- to hidden.

dieterholvoet opened merge request !34

dieterholvoet’s picture

dieterholvoet commented
Issue summary: View changes
Status: Active » Needs review
dieterholvoet’s picture

dieterholvoet commented

It also doesn't make sense to mark this module as compatible with Drupal 12, so I removed that. Drupal 12 isn't ready yet, there probably will be more upcoming breaking changes.

dieterholvoet’s picture

dieterholvoet commented
Related issues: +#3434953: Automated Drupal 11 compatibility fixes for term_reference_tree
nikhil_110’s picture

nikhil_110 commented
StatusFileSize
new Screenshot-1-before-patch.png631.69 KB
new Screenshot-2-after-patch.png338.97 KB

I was able to reproduce this issue after updating the module.

Error received:

Error: Class "Drupal\Core\Render\Element\FormElementBase" not found

This occurred on Drupal 9.5.11 to 10

I applied the patch provided in this issue, and it resolved the problem. The module is now working as expected without any errors.

Thanks for providing the fix.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @dieterholvoet!

vladimiraus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 2.0.2 » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

Thank you for your contributions! 🍻
Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.