Problem/Motivation

Line-height is too small for .pb-project__link

Steps to reproduce

Look at a card view with something that wraps to two lines, like "Scheduler content moderation integration" module

Proposed resolution

Change the line-height to 1 or 1.1 for .pb-project__link in the pb.css

CommentFileSizeAuthor
#5 After_line_height.png78.61 KByasminorj
#5 before_line_height.png80.63 KByasminorj

Issue fork project_browser-3495330

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

yasminorj’s picture

yasminorj commented

Hi, I'll take a look at this one

yasminorj changed the visibility of the branch 2.0.x to hidden.

yasminorj opened merge request !654

yasminorj’s picture

yasminorj commented
StatusFileSize
new before_line_height.png80.63 KB
new After_line_height.png78.61 KB

Hi, I applied a line-height of 2.2rem to evaluate its effect. Next, I'll mark it as 'needs review' to gather feedback.
Before: line-height: 1.125rem;

before

After: line-height: 2.2rem;

after

Let me know if you need additional adjustments!

yasminorj’s picture

yasminorj commented
Status: Active » Needs review
utkarsh_33’s picture

utkarsh_33 commented

This is duplicate of The project title's line height is a bit off..We can close any one of them.

lavanyatalwar’s picture

lavanyatalwar commented

Hi @yasminorj,
Thank you for providing the MR. I applied MR!654, and it was successfully applied, fixing the specified issue.
Thank you,
Moving it to RTBC.

lavanyatalwar’s picture

lavanyatalwar commented
Status: Needs review » Reviewed & tested by the community
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Duplicate of #3494978: The project title's line height is a bit off. - I created this not knowing the other existed. Both are fine fixes but we prefered the 1.75 line height. ;)