Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'm not sure if this is a bug or if I just missed something. After updating to Views 2.2 the single calendar nodes do not show up in a popup at the calendar view anymore but it opens a new page with the particular node.
Confirming also. I reverted to last views for a while, works again, but now decided to stay with the latest views as I am not sure what the critical security updates are.
Are the popups supposed to work automatically after the module is enabled? I have been looking all over for a way to turn them on but maybe I just have this bug.
The entire calendar module? Do you mean to overwrite a newly zipped copy of the calendar module with the changes in the file, then possibly run update.php ? Or is it just supposed to work if you overwrite the jcalendar.module file on the server with the changes? The 2nd is what I did, and it doesn't work. Attempted update.php with this method and no change.
--Edit
Just rezipped a copy of the calendar module with the changes. Overwrote the module, disabled all modules, re-enabled per http://drupal.org/node/349388 and is STILL not opening in popup. So what gives???
Once you make the changes to the module you need to reinstall the Calendar Popup module only. Just uncheck it save changes, then check it and save changes.
My patch only makes changes to the jcalendar.module as that's all that needed.
Please take a look. I've done as you stated in #18 as well as the entire process I've outlined in #17 and still no change, popup still doesn't function at all. This is Drupal 6.8, php 5.2, on GoDaddy's server (if this info helps any).
It looks fine. I've tried to duplicate the problem I can't seem to get it not to pop up. Can you tell me a bit about how you're calendar view is set up? Is it the default calendar view? or is it a clone of the default calendar view? Are you using the month, year, day view?
Is it a calendar page? or a calendar block? also do you have the calendar style selection on the views?
Thank you for the time in looking at the code. All of a sudden it's working. Perhaps was a GoDaddy issue where it didn't take the overwritten file.
Thank you again.
I'm building a site with Drupal 6.8, calendar-6.x-2.0-rc6 and views-6.x-2.2. (I also have views_tabs-6.x-1.x-dev enabled, if you think that may have an impact on this.)
Popup has not worked from the beginning (links just lead to full page views), and I was looking around for reasons or missed config settings when I ran across this thread.
I tried applying the patch posted above, but it did not work for me. I only patched on Windows (test site), doing it (1) manually by cutting and pasting, then (2) tried again using the Patch utility (in case I'd done something wrong before). Both times, after patching, I disabled the Popup module, saved config, then enabled and saved again. No change either time.
My calendar block comes from the original included view, but I created a custom Event content type and changed the date argument/field/sort to the CCK date field I'd created for that, and then filtered by Event type. I think that's all I changed from the original.
brings me back to the old trouble, now I get the popup, but it is hanging again as I saw earlier. This seams to be host/server environment dependent as it works on a different host -- strangely.
This hack below with that '... /jcalendar.js?747' helped, even I have no clue what it exactly did. But now it dose not and I get the plain node view again... :-(
Any help is very welcome, really love the popup if working :-) (my server does not have clean URL support)
-------
dwees - October 3, 2008 - 22:18
This is what I ended up doing:
/**
* Override the calendar view to inject javascript.
* @param view Which view we are using.
* @return unknown as of yet.
*/
function jcalendar_views_pre_view(&$view) {
if ($view->calendar_display == 'calendar') {
$clean_url = variable_get("clean_url", 0) ? "" : "?q=";
$path = drupal_get_path('module', 'jcalendar');
drupal_add_js('var var_path = ' . drupal_to_js($path) . ";", 'inline');
drupal_add_js('var var_base_path = ' . drupal_to_js($clean_url) . ";", 'inline');
drupal_add_js($path . '/jcalendar.js?747');
drupal_add_css($path . '/jcalendar.css');
}
}
Note that I don't even use base_path() at all. I'm sure there's some better way of doing this, but this worked on my server with clean-urls disabled.
I have the latest Dev downloaded on Jan 13. I've tried the patch_254 file as well as the above listed comment #28 patch and so far nothing has gotten Calendar Popup to work. Have tried IE, Foxfire, and Chrome. No errors reported on the console. HTML reports inclusion of jcalendar css and js files, so that is working properly. Later on I notice this:
The date is underlined properly to indicate an event on Jan 15, class month mini-day-on vs mini-day-off. But it also uses class calendar-empty just like the rest of the calendar. Are there other settings that I need to be looking for calendar block popup to work?
Views 2.2
CCK 2.1
Date RC6
Calendar Jan 13 Dev
Drupal 6.8
w/ and w/o Clean URL
Just wanted to report that the popup works as expected from the calendar full node view. It only seems to be broken in the block. In the block, I click on the underlined date and it takes me to the calendar view instead of giving me the calendar popup. Once the calendar view appears, however, I can click on the link and get the popup.
The only what give my calendar the popup funktion its: i activade the Block: calendar
But, this Calendar Block works wrong in the vies of week and day events:(
Is this block aktiv the popup goes on all my calendars... but without i have no popups.
I have look to the views and experiment with the pfads usw.. but nothink help.
Think i test it with an older version of views again.. many tell from this prob again upgrade from views.
Greets from Germany
Michael
* I test the patch codes ...but that help not. atm the only Way to activate the poup its activate the Block: Calendar
I'm having this problem as well. It seems that if I use the default calendar view then the jcalendar.js file is loaded. If I make my own view and choose calendar as my display type, then it is not loaded.
I need to make several different pages and even if I clone the default calendar view and add pages I don't get the js... only the pre-made page display will do it.
Comments
Comment #1
matthewn CreditAttribution: matthewn commentedJust chiming in to say I experience the same trouble after upgrading to Views 2.2.
Comment #2
tobiass CreditAttribution: tobiass commentedThank you for confirming this issue.
Correcting the title
Comment #3
captain-1 CreditAttribution: captain-1 commentedI also have the same issue after upgrading views.
Comment #4
davidcalvache CreditAttribution: davidcalvache commentedI have the exact same problem!... after updating my Views module to Views 2.2, Calendar Popup stops working.
Comment #5
jriedel CreditAttribution: jriedel commentedI just notied the same thing. It also happen with calendar 6.x-2.0-rc4
Comment #6
pyzahl CreditAttribution: pyzahl commentedConfirming also. I reverted to last views for a while, works again, but now decided to stay with the latest views as I am not sure what the critical security updates are.
So I have the same issue here (http://sbra.olotltd.com/?q=calendar), no pop ups -- any fix?
Comment #7
chadcross CreditAttribution: chadcross commentedAre the popups supposed to work automatically after the module is enabled? I have been looking all over for a way to turn them on but maybe I just have this bug.
Comment #8
pyzahl CreditAttribution: pyzahl commentedwere just working per default before. No setting, not that I know about.
compare to this (similar test site with still older views installed) http://sbra.pyzahl.net/?q=calendar
Comment #9
ericduran CreditAttribution: ericduran commentedI just had a quick look at this. It seems it's not picking up when the calendar view is being loaded.
This can be fix by commenting out line 63 and 69 on the jcalendar.module file under jcalendar.
So this is just a quick work around not to be use as a permanent solution. Since this will load the script on all views.
I'll try to get a patch up for KarenS.
Comment #10
chales CreditAttribution: chales commentedI am having the same problem. Found this post, http://drupal.org/node/301424 and like them my jcalendar.js is not being added.
Comment #11
Renee S CreditAttribution: Renee S commentedsubscribing
Comment #12
jefchenko CreditAttribution: jefchenko commentedI'm having the same problem when upgrading to views 2.2.
Would very much appreciate a patch! Those pop-ups were very nice.. :)
Comment #13
carla u CreditAttribution: carla u commentedsubscribing
Comment #14
ericduran CreditAttribution: ericduran commentedHere's a patch.
Comment #15
layoric CreditAttribution: layoric commentedEdited the file, applying the additions/subtractions per the patch, NO change.
- Layoric
Comment #16
ericduran CreditAttribution: ericduran commentedshould work. After you make the changes make sure you reinstall the module.
Comment #17
layoric CreditAttribution: layoric commentedThe entire calendar module? Do you mean to overwrite a newly zipped copy of the calendar module with the changes in the file, then possibly run update.php ? Or is it just supposed to work if you overwrite the jcalendar.module file on the server with the changes? The 2nd is what I did, and it doesn't work. Attempted update.php with this method and no change.
--Edit
Just rezipped a copy of the calendar module with the changes. Overwrote the module, disabled all modules, re-enabled per http://drupal.org/node/349388 and is STILL not opening in popup. So what gives???
Comment #18
ericduran CreditAttribution: ericduran commentedOnce you make the changes to the module you need to reinstall the Calendar Popup module only. Just uncheck it save changes, then check it and save changes.
My patch only makes changes to the jcalendar.module as that's all that needed.
Comment #19
layoric CreditAttribution: layoric commentedI must be missing something. This still isn't working. Here's my code: http://drupal.pastebin.com/m7831fb34
Please take a look. I've done as you stated in #18 as well as the entire process I've outlined in #17 and still no change, popup still doesn't function at all. This is Drupal 6.8, php 5.2, on GoDaddy's server (if this info helps any).
Comment #20
ericduran CreditAttribution: ericduran commentedIt looks fine. I've tried to duplicate the problem I can't seem to get it not to pop up. Can you tell me a bit about how you're calendar view is set up? Is it the default calendar view? or is it a clone of the default calendar view? Are you using the month, year, day view?
Is it a calendar page? or a calendar block? also do you have the calendar style selection on the views?
Comment #21
layoric CreditAttribution: layoric commentedThank you for the time in looking at the code. All of a sudden it's working. Perhaps was a GoDaddy issue where it didn't take the overwritten file.
Thank you again.
Comment #22
ericduran CreditAttribution: ericduran commentedno problem. Glad to see is working.
Comment #23
jriedel CreditAttribution: jriedel commentedI just applied this patch on RC4 and now the popups work again.
Comment #24
jefchenko CreditAttribution: jefchenko commentedThanks!
works like a charm...
Comment #25
Renee S CreditAttribution: Renee S commentedPatch worked for me!
Comment #26
dweller CreditAttribution: dweller commentedI'm building a site with Drupal 6.8, calendar-6.x-2.0-rc6 and views-6.x-2.2. (I also have views_tabs-6.x-1.x-dev enabled, if you think that may have an impact on this.)
Popup has not worked from the beginning (links just lead to full page views), and I was looking around for reasons or missed config settings when I ran across this thread.
I tried applying the patch posted above, but it did not work for me. I only patched on Windows (test site), doing it (1) manually by cutting and pasting, then (2) tried again using the Patch utility (in case I'd done something wrong before). Both times, after patching, I disabled the Popup module, saved config, then enabled and saved again. No change either time.
My calendar block comes from the original included view, but I created a custom Event content type and changed the date argument/field/sort to the CCK date field I'd created for that, and then filtered by Event type. I think that's all I changed from the original.
Thanks for your help.
Comment #27
KarenS CreditAttribution: KarenS commentedNot sure why the old code suddenly quit working but the patch works fine, so thanks! I've committed it.
Comment #28
pyzahl CreditAttribution: pyzahl commentedHello again!
Installed latest -dev for 6.0.
brings me back to the old trouble, now I get the popup, but it is hanging again as I saw earlier. This seams to be host/server environment dependent as it works on a different host -- strangely.
This hack below with that '... /jcalendar.js?747' helped, even I have no clue what it exactly did. But now it dose not and I get the plain node view again... :-(
Any help is very welcome, really love the popup if working :-) (my server does not have clean URL support)
-------
dwees - October 3, 2008 - 22:18
This is what I ended up doing:
Note that I don't even use base_path() at all. I'm sure there's some better way of doing this, but this worked on my server with clean-urls disabled.
Comment #29
khawaja CreditAttribution: khawaja commentedI have the latest Dev downloaded on Jan 13. I've tried the patch_254 file as well as the above listed comment #28 patch and so far nothing has gotten Calendar Popup to work. Have tried IE, Foxfire, and Chrome. No errors reported on the console. HTML reports inclusion of jcalendar css and js files, so that is working properly. Later on I notice this:
The date is underlined properly to indicate an event on Jan 15, class month mini-day-on vs mini-day-off. But it also uses class calendar-empty just like the rest of the calendar. Are there other settings that I need to be looking for calendar block popup to work?
Views 2.2
CCK 2.1
Date RC6
Calendar Jan 13 Dev
Drupal 6.8
w/ and w/o Clean URL
Comment #30
dweller CreditAttribution: dweller commentedJust wanted to report that the popup works as expected from the calendar full node view. It only seems to be broken in the block. In the block, I click on the underlined date and it takes me to the calendar view instead of giving me the calendar popup. Once the calendar view appears, however, I can click on the link and get the popup.
Anyone else have this problem? Thanks.
Comment #31
KarenS CreditAttribution: KarenS commentedThe new issue is a duplicate that was reported already in several places and has since been fixed.
Comment #32
amirtaiar CreditAttribution: amirtaiar commentedI didnt understand where should I put the patch?
seems like its working for most peaple here so I will keep on with th rc6.0.
Comment #33
Nashuja CreditAttribution: Nashuja commentedHi all,
i have this prob to..
The only what give my calendar the popup funktion its: i activade the Block: calendar
But, this Calendar Block works wrong in the vies of week and day events:(
Is this block aktiv the popup goes on all my calendars... but without i have no popups.
I have look to the views and experiment with the pfads usw.. but nothink help.
Think i test it with an older version of views again.. many tell from this prob again upgrade from views.
Greets from Germany
Michael
* I test the patch codes ...but that help not. atm the only Way to activate the poup its activate the Block: Calendar
Comment #34
Sinan Erdem CreditAttribution: Sinan Erdem commentedSame for me...
Comment #35
soyarma CreditAttribution: soyarma commentedI'm having this problem as well. It seems that if I use the default calendar view then the jcalendar.js file is loaded. If I make my own view and choose calendar as my display type, then it is not loaded.
I need to make several different pages and even if I clone the default calendar view and add pages I don't get the js... only the pre-made page display will do it.
Comment #36
paganwinter CreditAttribution: paganwinter commentedSubscribing...Subscribing...
Comment #37
momper CreditAttribution: momper commentedsubscribing
Comment #38
theohawse CreditAttribution: theohawse commentedPopups are broken for me to, what gives?