Integrate responsive preview with Navigation top bar

I am facing issue setting up the responsive preview module. Attaching the screen recording video for reference.

I encountered an issue while working with the responsive_preview module. The error was as follows:

Error: Call to undefined function drupal_common_theme() in responsive_preview_theme() (line 40 of modules/contrib/responsive_preview/responsive_preview.module)

I resolved it by modifying the code in the responsive_preview_theme() function. Could you please confirm whether this should be addressed as a separate issue, or can we include the fix under the scope of the current issue?

Additionally, I need clarification regarding the default dimensions for the device icons. What dimensions should we use for both devices? Please provide the recommended width and height values to standardize the implementation.

I would like to clarify that I am still facing the issue. In my previous comment, I mentioned that it was working, but that was due to a version mismatch. The issue persists as follows:

• When the Responsive Preview block is placed, the buttons are displayed but do not function as expected.
• If the Navigation module is uninstalled, the Responsive Preview list displays correctly in the toolbar and works perfectly.

The Responsive Preview block was not functioning as expected due to the missing #block-responsivepreviewcontrols ID when the block was placed. After adding the required ID, the block started working as intended. With this issue resolved, I am now unblocked and able to continue working on it.

@roshni upadhyay Thank you for your work on this one.

After reading the code, I have some ideas to make it a bit more generic:

* We could create the navigation top bar as a submodule, or even a new contrib module that depends on this one and navigation. Let's work on a MR for this one for now.
* Add a 3rd party setting to the config entity as part of this submodule to "Show in Top Bar" the responsive_preview entity
* Instead of hardcoding the types in ResponsiveIcons class, load the items whose 3rd party setting is defined to be shown in the top bar
* Think in a way of how to display those options different from "mobile" & "desktop". That could be part of a follow-up issue

Another approach could be to make it fully hardcoded, and do not make use of the config entities, and use the original module as an API to provide the logic to switch between devices, but not crating new entities, nor using them.

This 2nd approach could be simpler to implement at this point, but we will probably want something more generic in the long term.

Discussed with @plopesc and @roshni upadhyay to align on the approach. We agreed that we will continue with the approach proposed in #11. What we will do is:

1. Create a new submodule specifically for Drupal CMS (and Experience Builder)
2. For now, the submodule will not be using the Device config entity but we will hard code those values in the Drupal\navigation\TopBarItemBase implementation which will allow us to provide a good experience consistently
3. We will avoid making changes to the main module for now so that we can ship the submodule in a separate project if necessary
4. In future, we might integrate the device settings with Experience Builder to automatically define them based on what has been configured there.

Changes look great and goes in the right direction.

Added some comments in the MR that might need to be addressed.

Made a couple of minor adjustments, but overall, I think this is ready for final review.

This looks pretty good based on the functionality and code has been reviewed by @plopesc.

I think an important follow-up to this would be to render the responsive preview as an anonymous user. That might lead into some complications so it's better to leave that to another issue.

Created follow-up #3501374: Preview displays include Navigation Toolbars

Rebased, will merge this and wait for the follow-up #3501374: Preview displays include Navigation Toolbars.

Merged! will wait for the follow-up #3501374: Preview displays include Navigation Toolbars.

Thank you for this integration, hoping that it could be released

1- The following issue was committed and released in Drupal Core.
#3484564: Define the 3 areas the Top Bar will provide

2- Not listing all devices. (Should we do that? )
3- Have an option to show the dropdown. (Should we do that?)
4- A new project could have better management ( not sure if this could end up in Drupal Core or Drupal CMS )

One more question:
Should the getResponsivePreviewItems method be filled with the dynamic configs and use the Icon API?

Moving to adopt the committed method, and enable the new sub module.

Answering my own questions after an internal meeting with my teams:

1- The following issue was committed and released in Drupal Core.
#3484564: Define the 3 areas the Top Bar will provide

• The tools regions is the right region for the Responsive Preview Navigation featured devices buttons

2- Not listing all devices. (Should we do that? )

• No need to list
• Happy with what was committed ( moving forward with this UX/UI )

3- Have an option to show the dropdown. (Should we do that?)

• No need for that

4- A new project could have better management ( not sure if this could end up in Drupal Core or Drupal CMS )

• Starting to use the Responsive Preview Navigation in our products.
• When Drupal CMS change logic, we will recalculate and follow with the better UX/UI logic.
• Having the following fixes too
  • #3531527: Gin: button font - Thanks, Florent
  • #3501374: Preview displays include Navigation Toolbars - Thanks, Pablo

Hoping for a tag release

Released 2.3.0!