Problem/Motivation

https://git.drupalcode.org/project/ckeditor5_premium_features/-/blob/1.3... has 'DocumentList' which results in this failure:

ckeditor5-dll.js?v=41.3.1:5 plugin-obsolete-documentlist Object
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-p…
n @ ckeditor5-dll.js?v=41.3.1:5

The same with ckeditor5_premium_features_collaboration.ckeditor5.yml

Steps to reproduce

Attempt to use realtime or non-realtime collaboration

Proposed resolution

Fix use of deprecated code

Remaining tasks

Not sure

User interface changes

Note sure

API changes

Not sure

Data model changes

Not sure

CommentFileSizeAuthor
#9 3482650_1.4.x_9.patch20 KBjkamizato
#8 3482650_1.4.x_8.patch10 KBjkamizato
#6 3482650_6.patch10.21 KBsalmonek
#3 3482650_3.patch9.79 KBsalmonek

Issue fork ckeditor5_premium_features-3482650

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser’s picture

scott_euser commented
Title: Realtime Collaboration results in DocumentList error » Realtime and non-realtime Collaboration result in DocumentList error
salmonek’s picture

salmonek commented
Status: Active » Postponed
StatusFileSize
new 3482650_3.patch9.79 KB

Hi @scott_euser
We're aware of this warning. It is being kept for backwards compatibility and as for now besides displaying warning it doesn't produce errors.
DocumentList plugin is used in Comments and Collaboration (as suggestions can be commented), it allows to add list in comment (using autoformat functionality).
In Drupal up to 10.2 with CKEditor 5 versions prior to 41.0.0 there were available plugins DocumentList and List (incompatible with Drupal's core CKEditor 5 build).
CKEditor 5 v41.0.0 (v41.3.1 is in Drupal 10.3) changed the plugin names:
DocumentList -> List
List -> LegacyList
DocumentList became obsolete, but sill an alias for List

The problem with changing plugin used in the module to List would be that for sites using Drupal prior to 10.3 it would mean to change to unsupported plugin.
So up until DocumentList is kept as alias (or we'll gain info that it causes some error), we'll be willing to not put that change into official release.
In case you would like to get rid of that warning I'm posting a patch that is compatible with Premium Features v1.3.2 which chnages the plugin.

I'll set the status to postponed. We can close after chnage will land in official release.

scott_euser’s picture

scott_euser commented

Okay sounds good, and thanks for the patch!

scott_euser’s picture

scott_euser commented

I did try out the patch but actually that leads to a complete error rather than warning, so will leave it off for now.

Here is the error in case you need it:

ckeditor5.js?sluq6o:464 Debugging can be done with an unminified version of CKEditor by installing from the source file. Consult documentation at https://www.drupal.org/node/3258901
hook.js:608 CKEditorError: plugincollection-soft-required {"missingPlugin":"DocumentList","requiredBy":"CommentsAdapter"}
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-plugincollection-soft-required
    at ckeditor5-dll.js?v=41.3.1:5:125401
    at ckeditor5-dll.js?v=41.3.1:5:125545
    at Array.forEach (<anonymous>)
    at u (ckeditor5-dll.js?v=41.3.1:5:125347)
    at ckeditor5-dll.js?v=41.3.1:5:123978
    at Array.reduce (<anonymous>)
    at e (ckeditor5-dll.js?v=41.3.1:5:123929)
    at l.init (ckeditor5-dll.js?v=41.3.1:5:124054)
    at V.initPlugins (ckeditor5-dll.js?v=41.3.1:5:133962)
    at editor-classic.js?v=41.3.1:4:10883
salmonek’s picture

salmonek commented
StatusFileSize
new 3482650_6.patch10.21 KB

Attaching updated patch.
Previous one didn't change library version, so besides cache rebuild a browser's cache flush was required.
This one requires only cache rebuild.

mdusza’s picture

mdusza commented

Keeping postponed as we're not able to resolve it as long as we support Drupal 10.2

jkamizato’s picture

jkamizato commented
StatusFileSize
new 3482650_1.4.x_8.patch10 KB

Patch for 1.4-x version

jkamizato’s picture

jkamizato commented
StatusFileSize
new 3482650_1.4.x_9.patch20 KB

Patch 8 was wrong.... sending #9

mdusza’s picture

mdusza commented
Status: Postponed » Active

salmonek opened merge request !36

salmonek’s picture

salmonek commented
Version: 1.3.2 » 1.6.0
Status: Active » Needs review

In version 1.6.0 we have bumped required Drupal version to 10.3, so we can now replace deprecated DocumentList in the next release.
The patch compatible with 1.6.0 is available through gitlab MR

salmonek’s picture

salmonek commented
Status: Needs review » Reviewed & tested by the community

Fix verified by our QA team, merget to 1.6.x

salmonek’s picture

salmonek commented
Status: Reviewed & tested by the community » Fixed

Released in 1.6.1 which was broken by wrong commit merge of another issue. Hotfix version 1.6.2 is already released.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.