I'm adding a component to a slot that has a placeholder. When I'm dragging the component over the slot, the slot starts flickering.
Another example taken from #3481347: Canvas flickers when adding a component to an empty slot when the canvas is empty: It may or may not have the same root cause.
New and improved look for Root overlay
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | Screenshot 2024-12-02 at 3.08.48 PM.png | 41.7 KB | lauriii |
| #14 | xb-root-layout-border.gif | 8.2 MB | jessebaker |
| CleanShot 2024-09-23 at 13.02.49-converted.gif | 551.91 KB | lauriii |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersComment #3
cosmicdreams commentedIn general, the dropzone for the slot is relatively small / short? Are we opposed to making the dropzone taller (have more height)?
Comment #4
wim leers#3: are you referring to empty slots, or to already-populated slots?
Comment #5
gauravvvv commentedComment #6
gauravvvv commentedI am unable to access these demo components. Is there a way to place them on the page?
Comment #7
cosmicdreams commented#4 I am referring to the empty slots.
Sorry @wim leers I just know saw you asked me that.
Comment #8
kristen polThanks for reporting... I saw this a lot but forgot to add an issue.
Comment #9
traviscarden commentedI've marked #3481347: Canvas flickers when adding a component to an empty slot as a duplicate of this issue and added the screenshot and additional detail from it to this issue's summary. I don't know if they have the same root cause. If they turn out not to and can't be easily solved at the same time, we can re-open that issue.
Comment #10
jessebaker commentedComment #14
jessebaker commentedComment #15
lauriiiNice! This definitely makes creating pages from scratch feel more polished! Few refinements we could do in a follow-up:
Comment #16
wim leersTHOSE COLOR CODE AFFORDANCES! 🤩👏
Comment #17
wim leersCross-posted with @lauriii's #15. I don't think people will see #15 while this is marked "fixed" 😅
Comment #18
jessebaker commentedThe root concept is going away once there is more than one region and will be replaced with a 'content' region - I think perhaps that can be named after the region. I made it green for now as it's closest to what a region will be. Blue = component, purple = component slot and green = region. I think that's correct based on the designs.
Comment #19
wim leersIt sounds like @jessebaker's saying in #18 that actually there is no need for a follow-up.
Let's see if @lauriii agrees.
Comment #20
lauriii#18: That description does not exactly match the use of the colors defined by design. Even though the root is close to a region, it doesn't cascade outside the current page. Therefore we should not be using green for the root as green is supposed to signify that changes inside that area cascade outside the current page.
Blue vs purple is supposed to signify components vs elements. We don't really have elements at this point so pretty much everything should be either purple or green.
Slots don't have their own color at the moment; they should inherit the color of their parent. In this case since we're using components, they should be purple.
Comment #21
jessebaker commentedNot saying we shouldn't follow up at all, just that it's a bit premature at this point as the data model is in the process of changing.
At the moment root = green, component = blue, slot = purple but with the new data model we will have a data model that represents regions, components, elements, slots and the current page/content area so all the styling and the data it is based on will be changing. I'm not sure it makes sense to have a specific issue just for changing the colours now rather than just applying the right colours once we have the right data model underpinning it all.
I think once the data model is in, it will be trivial to attribute the right colours to the right things and then we can go through with UX with working examples to iterate on.
Comment #22
wim leersI'm writing the XB blog post for week 29 and … this issue landed in that week, yet it's still open 😅
Everything in #21 actually kinda perfectly predicts @jessebaker's very own #3498819-5: [Needs design] Adjust representation of Regions in the Layers UI 😅
I think that means this is fine to close? 😇
Comment #23
jessebaker commentedYup, closing this. #3498819 can pick up the design related follow ups.